From 4166f73d9da4d28bc46c66fd7c0cd9a62e74d9c6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E8=AF=97=E6=B5=93?= <844670992@qq.com>
Date: Wed, 16 Apr 2025 17:26:47 +0800
Subject: [PATCH] fix: page/limit param not effective (#18196)

---
 api/controllers/service_api/dataset/segment.py |  2 ++
 api/services/dataset_service.py                | 15 +++++++++++----
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/api/controllers/service_api/dataset/segment.py b/api/controllers/service_api/dataset/segment.py
index 3d5869c371..2a79e15cc5 100644
--- a/api/controllers/service_api/dataset/segment.py
+++ b/api/controllers/service_api/dataset/segment.py
@@ -122,6 +122,8 @@ class SegmentApi(DatasetApiResource):
             tenant_id=current_user.current_tenant_id,
             status_list=args["status"],
             keyword=args["keyword"],
+            page=page,
+            limit=limit,
         )
 
         response = {
diff --git a/api/services/dataset_service.py b/api/services/dataset_service.py
index deb6be5a43..b08d70489a 100644
--- a/api/services/dataset_service.py
+++ b/api/services/dataset_service.py
@@ -2175,7 +2175,13 @@ class SegmentService:
 
     @classmethod
     def get_segments(
-        cls, document_id: str, tenant_id: str, status_list: list[str] | None = None, keyword: str | None = None
+        cls,
+        document_id: str,
+        tenant_id: str,
+        status_list: list[str] | None = None,
+        keyword: str | None = None,
+        page: int = 1,
+        limit: int = 20,
     ):
         """Get segments for a document with optional filtering."""
         query = DocumentSegment.query.filter(
@@ -2188,10 +2194,11 @@ class SegmentService:
         if keyword:
             query = query.filter(DocumentSegment.content.ilike(f"%{keyword}%"))
 
-        segments = query.order_by(DocumentSegment.position.asc()).all()
-        total = len(segments)
+        paginated_segments = query.order_by(DocumentSegment.position.asc()).paginate(
+            page=page, per_page=limit, max_per_page=100, error_out=False
+        )
 
-        return segments, total
+        return paginated_segments.items, paginated_segments.total
 
     @classmethod
     def update_segment_by_id(