From 648393cc7bc1347f93b40ec24e563405b416ae60 Mon Sep 17 00:00:00 2001
From: jameshui1997 <115518541+jameshui1997@users.noreply.github.com>
Date: Thu, 22 May 2025 14:08:36 +0800
Subject: [PATCH] fix: improve tracing provider validation logic in
 OpsTraceManager (#20042)

---
 api/core/ops/ops_trace_manager.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/api/core/ops/ops_trace_manager.py b/api/core/ops/ops_trace_manager.py
index a3424c7421..32301e11e7 100644
--- a/api/core/ops/ops_trace_manager.py
+++ b/api/core/ops/ops_trace_manager.py
@@ -292,11 +292,14 @@ class OpsTraceManager:
         :return:
         """
         # auth check
-        if tracing_provider is not None:
+        if enabled == True:
             try:
                 provider_config_map[tracing_provider]
             except KeyError:
                 raise ValueError(f"Invalid tracing provider: {tracing_provider}")
+        else:
+            if tracing_provider is not None:
+                raise ValueError(f"Invalid tracing provider: {tracing_provider}")
 
         app_config: Optional[App] = db.session.query(App).filter(App.id == app_id).first()
         if not app_config: