From 85eeaee95a868fda6c487ab289a2f68d68a1feab Mon Sep 17 00:00:00 2001
From: Joel <iamjoel007@gmail.com>
Date: Thu, 8 Aug 2024 14:40:08 +0800
Subject: [PATCH] feat: vision valid

---
 web/app/components/workflow/nodes/llm/default.ts               | 2 ++
 .../components/workflow/nodes/parameter-extractor/default.ts   | 2 ++
 .../components/workflow/nodes/question-classifier/default.ts   | 3 +++
 web/i18n/en-US/workflow.ts                                     | 1 +
 web/i18n/zh-Hans/workflow.ts                                   | 1 +
 5 files changed, 9 insertions(+)

diff --git a/web/app/components/workflow/nodes/llm/default.ts b/web/app/components/workflow/nodes/llm/default.ts
index 803add6f00..c5848ef437 100644
--- a/web/app/components/workflow/nodes/llm/default.ts
+++ b/web/app/components/workflow/nodes/llm/default.ts
@@ -79,6 +79,8 @@ const nodeDefault: NodeDefault<LLMNodeType> = {
         })
       }
     }
+    if (!errorMessages && payload.vision.enabled && !payload.vision.configs?.valueSelector.length)
+      errorMessages = t(`${i18nPrefix}.fieldRequired`, { field: t(`${i18nPrefix}.fields.visionVariable`) })
     return {
       isValid: !errorMessages,
       errorMessage: errorMessages,
diff --git a/web/app/components/workflow/nodes/parameter-extractor/default.ts b/web/app/components/workflow/nodes/parameter-extractor/default.ts
index 125d469aea..ab4ef82a53 100644
--- a/web/app/components/workflow/nodes/parameter-extractor/default.ts
+++ b/web/app/components/workflow/nodes/parameter-extractor/default.ts
@@ -57,6 +57,8 @@ const nodeDefault: NodeDefault<ParameterExtractorNodeType> = {
           errorMessages = t(`${i18nPrefix}.errorMsg.fieldRequired`, { field: t(`${i18nPrefix}.nodes.parameterExtractor.addExtractParameterContent.descriptionPlaceholder`) })
       })
     }
+    if (!errorMessages && payload.vision.enabled && !payload.vision.configs?.valueSelector.length)
+      errorMessages = t(`${i18nPrefix}.errorMsg.fieldRequired`, { field: t(`${i18nPrefix}.errorMsg.fields.visionVariable`) })
     return {
       isValid: !errorMessages,
       errorMessage: errorMessages,
diff --git a/web/app/components/workflow/nodes/question-classifier/default.ts b/web/app/components/workflow/nodes/question-classifier/default.ts
index 201699b95e..65b0cac588 100644
--- a/web/app/components/workflow/nodes/question-classifier/default.ts
+++ b/web/app/components/workflow/nodes/question-classifier/default.ts
@@ -53,6 +53,9 @@ const nodeDefault: NodeDefault<QuestionClassifierNodeType> = {
 
     if (!errorMessages && (payload.classes.some(item => !item.name)))
       errorMessages = t(`${i18nPrefix}.errorMsg.fieldRequired`, { field: t(`${i18nPrefix}.nodes.questionClassifiers.topicName`) })
+
+    if (!errorMessages && payload.vision.enabled && !payload.vision.configs?.valueSelector.length)
+      errorMessages = t(`${i18nPrefix}.errorMsg.fieldRequired`, { field: t(`${i18nPrefix}.errorMsg.fields.visionVariable`) })
     return {
       isValid: !errorMessages,
       errorMessage: errorMessages,
diff --git a/web/i18n/en-US/workflow.ts b/web/i18n/en-US/workflow.ts
index c4f760535e..01aea204b1 100644
--- a/web/i18n/en-US/workflow.ts
+++ b/web/i18n/en-US/workflow.ts
@@ -135,6 +135,7 @@ const translation = {
       code: 'Code',
       model: 'Model',
       rerankModel: 'Rerank Model',
+      visionVariable: 'Vision Variable',
     },
     invalidVariable: 'Invalid variable',
   },
diff --git a/web/i18n/zh-Hans/workflow.ts b/web/i18n/zh-Hans/workflow.ts
index e2e75ee470..eb28b5cb6f 100644
--- a/web/i18n/zh-Hans/workflow.ts
+++ b/web/i18n/zh-Hans/workflow.ts
@@ -135,6 +135,7 @@ const translation = {
       code: '代码',
       model: '模型',
       rerankModel: 'Rerank 模型',
+      visionVariable: '视觉变量',
     },
     invalidVariable: '无效的变量',
   },