From 8964ceba08323f45c918be1dacf211216c70a6dc Mon Sep 17 00:00:00 2001
From: zxhlyh <jasonapring2015@outlook.com>
Date: Fri, 12 Jan 2024 12:36:48 +0800
Subject: [PATCH] fix: model parameter default value (#2005)

---
 .../model-parameter-modal/index.tsx                 | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/web/app/components/header/account-setting/model-provider-page/model-parameter-modal/index.tsx b/web/app/components/header/account-setting/model-provider-page/model-parameter-modal/index.tsx
index d0febbc215..ac704574ac 100644
--- a/web/app/components/header/account-setting/model-provider-page/model-parameter-modal/index.tsx
+++ b/web/app/components/header/account-setting/model-provider-page/model-parameter-modal/index.tsx
@@ -19,6 +19,7 @@ import {
   useLanguage,
   useTextGenerationCurrentProviderAndModelAndModelList,
 } from '../hooks'
+import { isNullOrUndefined } from '../utils'
 import ParameterItem from './parameter-item'
 import type { ParameterValue } from './parameter-item'
 import {
@@ -171,11 +172,15 @@ const ModelParameterModal: FC<ModelParameterModalProps> = ({
   }
 
   const handleInitialParams = () => {
+    const newCompletionParams = { ...completionParams }
     if (parameterRules.length) {
-      const newCompletionParams = { ...completionParams }
-      Object.keys(newCompletionParams).forEach((key) => {
-        if (!parameterRules.find(item => item.name === key))
-          delete newCompletionParams[key]
+      parameterRules.forEach((parameterRule) => {
+        if (!newCompletionParams[parameterRule.name]) {
+          if (!isNullOrUndefined(parameterRule.default))
+            newCompletionParams[parameterRule.name] = parameterRule.default
+          else
+            delete newCompletionParams[parameterRule.name]
+        }
       })
 
       onCompletionParamsChange(newCompletionParams)