From 959a81a41b2e7d2a3f7a1f1d92961cc35c4727b3 Mon Sep 17 00:00:00 2001
From: zhuhao <37029601+hwzhuhao@users.noreply.github.com>
Date: Mon, 7 Oct 2024 11:08:06 +0800
Subject: [PATCH] refactor: remove the duplicate definitions across different
 modules (#9022)

---
 api/controllers/files/error.py         | 7 +++++++
 api/controllers/files/image_preview.py | 8 +-------
 api/controllers/files/tool_files.py    | 8 +-------
 3 files changed, 9 insertions(+), 14 deletions(-)
 create mode 100644 api/controllers/files/error.py

diff --git a/api/controllers/files/error.py b/api/controllers/files/error.py
new file mode 100644
index 0000000000..a7ce4cd6f7
--- /dev/null
+++ b/api/controllers/files/error.py
@@ -0,0 +1,7 @@
+from libs.exception import BaseHTTPException
+
+
+class UnsupportedFileTypeError(BaseHTTPException):
+    error_code = "unsupported_file_type"
+    description = "File type not allowed."
+    code = 415
diff --git a/api/controllers/files/image_preview.py b/api/controllers/files/image_preview.py
index 2432285d93..a56c1c332d 100644
--- a/api/controllers/files/image_preview.py
+++ b/api/controllers/files/image_preview.py
@@ -4,7 +4,7 @@ from werkzeug.exceptions import NotFound
 
 import services
 from controllers.files import api
-from libs.exception import BaseHTTPException
+from controllers.files.error import UnsupportedFileTypeError
 from services.account_service import TenantService
 from services.file_service import FileService
 
@@ -50,9 +50,3 @@ class WorkspaceWebappLogoApi(Resource):
 
 api.add_resource(ImagePreviewApi, "/files/<uuid:file_id>/image-preview")
 api.add_resource(WorkspaceWebappLogoApi, "/files/workspaces/<uuid:workspace_id>/webapp-logo")
-
-
-class UnsupportedFileTypeError(BaseHTTPException):
-    error_code = "unsupported_file_type"
-    description = "File type not allowed."
-    code = 415
diff --git a/api/controllers/files/tool_files.py b/api/controllers/files/tool_files.py
index 38ac0815da..406cd42214 100644
--- a/api/controllers/files/tool_files.py
+++ b/api/controllers/files/tool_files.py
@@ -3,8 +3,8 @@ from flask_restful import Resource, reqparse
 from werkzeug.exceptions import Forbidden, NotFound
 
 from controllers.files import api
+from controllers.files.error import UnsupportedFileTypeError
 from core.tools.tool_file_manager import ToolFileManager
-from libs.exception import BaseHTTPException
 
 
 class ToolFilePreviewApi(Resource):
@@ -43,9 +43,3 @@ class ToolFilePreviewApi(Resource):
 
 
 api.add_resource(ToolFilePreviewApi, "/files/tools/<uuid:file_id>.<string:extension>")
-
-
-class UnsupportedFileTypeError(BaseHTTPException):
-    error_code = "unsupported_file_type"
-    description = "File type not allowed."
-    code = 415