From ab127ba92e298827e0ae84c04a7a7acade29fdbd Mon Sep 17 00:00:00 2001
From: Cling_o3 <45124798+ProseGuys@users.noreply.github.com>
Date: Fri, 1 Nov 2024 18:59:15 +0800
Subject: [PATCH] [fix] fix the bug that modify document name not effective
 (#10154)

---
 api/services/dataset_service.py | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/api/services/dataset_service.py b/api/services/dataset_service.py
index ac05cbc4f5..50da547fd8 100644
--- a/api/services/dataset_service.py
+++ b/api/services/dataset_service.py
@@ -986,9 +986,6 @@ class DocumentService:
             raise NotFound("Document not found")
         if document.display_status != "available":
             raise ValueError("Document is not available")
-        # update document name
-        if document_data.get("name"):
-            document.name = document_data["name"]
         # save process rule
         if document_data.get("process_rule"):
             process_rule = document_data["process_rule"]
@@ -1065,6 +1062,10 @@ class DocumentService:
             document.data_source_type = document_data["data_source"]["type"]
             document.data_source_info = json.dumps(data_source_info)
             document.name = file_name
+
+        # update document name
+        if document_data.get("name"):
+            document.name = document_data["name"]
         # update document to be waiting
         document.indexing_status = "waiting"
         document.completed_at = None