AI/dify
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/langgenius/dify.git synced 2025-07-26 15:52:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

fix(variable_pool): handle invalid attributes in variable lookup (#9646)

Browse Source
This commit is contained in:
-LAN- 2024-10-23 10:19:33 +08:00 committed by GitHub
parent 01a2513812
commit d5a93a6400
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
api/core/workflow/entities/variable_pool.py
View File

@ -124,11 +124,15 @@ class VariablePool(BaseModel):
if value is None: if value is None:
selector, attr = selector[:-1], selector[-1] selector, attr = selector[:-1], selector[-1]
# Python support `attr in FileAttribute` after 3.12
if attr not in {item.value for item in FileAttribute}:
return None
value = self.get(selector) value = self.get(selector)
if isinstance(value, FileSegment): if not isinstance(value, FileSegment):
attr = FileAttribute(attr) return None
attr_value = file_manager.get_attr(file=value.value, attr=attr) attr = FileAttribute(attr)
return variable_factory.build_segment(attr_value) attr_value = file_manager.get_attr(file=value.value, attr=attr)
return variable_factory.build_segment(attr_value)
return value return value

4
api/tests/unit_tests/core/workflow/test_variable_pool.py
View File

@ -33,8 +33,8 @@ def test_get_file_attribute(pool, file):
assert result.value == file.filename assert result.value == file.filename
# Test getting a non-existent attribute # Test getting a non-existent attribute
with pytest.raises(ValueError): result = pool.get(("node_1", "file_var", "non_existent_attr"))
pool.get(("node_1", "file_var", "non_existent_attr")) assert result is None
def test_use_long_selector(pool): def test_use_long_selector(pool):