From 6bfd24d90338a098194b08d50c37c90f324fa9f9 Mon Sep 17 00:00:00 2001 From: Nicolas Date: Thu, 30 Jan 2025 23:23:03 -0300 Subject: [PATCH] Nick: waitFor fixes --- apps/api/src/controllers/v1/types.ts | 2 +- apps/api/src/scraper/scrapeURL/engines/fire-engine/index.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/apps/api/src/controllers/v1/types.ts b/apps/api/src/controllers/v1/types.ts index 7693ae04..465810ba 100644 --- a/apps/api/src/controllers/v1/types.ts +++ b/apps/api/src/controllers/v1/types.ts @@ -140,7 +140,7 @@ export const scrapeOptions = z excludeTags: z.string().array().optional(), onlyMainContent: z.boolean().default(true), timeout: z.number().int().positive().finite().safe().optional(), - waitFor: z.number().int().nonnegative().finite().safe().max(60000).default(0), + waitFor: z.number().int().nonnegative().finite().safe().max(30000).default(0), // Deprecate this to jsonOptions extract: extractOptions.optional(), // New diff --git a/apps/api/src/scraper/scrapeURL/engines/fire-engine/index.ts b/apps/api/src/scraper/scrapeURL/engines/fire-engine/index.ts index 50198ca7..eda8402d 100644 --- a/apps/api/src/scraper/scrapeURL/engines/fire-engine/index.ts +++ b/apps/api/src/scraper/scrapeURL/engines/fire-engine/index.ts @@ -151,9 +151,9 @@ export async function scrapeURLWithFireEngineChromeCDP( // Transform waitFor option into an action (unsupported by chrome-cdp) ...(meta.options.waitFor !== 0 ? [ - { + { type: "wait" as const, - milliseconds: meta.options.waitFor, + milliseconds: meta.options.waitFor > 30000 ? 30000 : meta.options.waitFor, }, ] : []),