AI/ragflow
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/infiniflow/ragflow.git synced 2025-08-12 18:49:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix: HTTP API Updates Read-Only Dataset Fields During Modification #5923 (#5937)

Browse Source 
### What problem does this PR solve?

Fixes #5923 

Fixes the readonly variables from payload at
 /datasets/<dataset_id> 

_Briefly describe what this PR aims to solve. Include background context
that will help reviewers understand the purpose of the PR._

Now if user tries to modify readonly values then it will show " The
input parameters are invalid. "

invalid_keys = {"id", "embd_id", "chunk_num", "doc_num", "parser_id",
"create_date", "create_time", "created_by",
"status","token_num","update_date","update_time"}
    if any(key in req for key in invalid_keys):
return get_error_data_result(message="The input parameters are
invalid.")
i have include those readonly keys in invalid_keys

### Type of change

- [ ] Bug Fix (non-breaking change which fixes an issue)

---------

Co-authored-by: Raghav <2020csb1115@iitrpr.ac.in>
This commit is contained in:
Raghav Patidar 2025-03-12 07:57:02 +05:30 committed by GitHub
parent 1c663b32b9
commit 49d560583f
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
api/apps/document_app.py
View File

@ -347,7 +347,7 @@ def rm():
@manager.route('/run', methods=['POST']) # noqa: F821 @manager.route('/run', methods=['POST']) # noqa: F821
@login_required @login_required
@validate_request("doc_ids", "run") @validate_request("doc_ids", "run")
def run(): def run():
req = request.json req = request.json
for doc_id in req["doc_ids"]: for doc_id in req["doc_ids"]:
if not DocumentService.accessible(doc_id, current_user.id): if not DocumentService.accessible(doc_id, current_user.id):

4
api/apps/sdk/dataset.py
View File

@ -276,7 +276,7 @@ def delete(tenant_id):
return get_result(code=settings.RetCode.SUCCESS) return get_result(code=settings.RetCode.SUCCESS)
@manager.route("/datasets/<dataset_id>", methods=["PUT"]) # noqa: F821 @manager.route("/datasets/<dataset_id>", methods=["PUT"]) # noqa: F821
@token_required @token_required
def update(tenant_id, dataset_id): def update(tenant_id, dataset_id):
""" """
@ -330,7 +330,7 @@ def update(tenant_id, dataset_id):
return get_error_data_result(message="You don't own the dataset") return get_error_data_result(message="You don't own the dataset")
req = request.json req = request.json
e, t = TenantService.get_by_id(tenant_id) e, t = TenantService.get_by_id(tenant_id)
invalid_keys = {"id", "embd_id", "chunk_num", "doc_num", "parser_id"} invalid_keys = {"id", "embd_id", "chunk_num", "doc_num", "parser_id", "create_date", "create_time", "created_by", "status","token_num","update_date","update_time"}
if any(key in req for key in invalid_keys): if any(key in req for key in invalid_keys):
return get_error_data_result(message="The input parameters are invalid.") return get_error_data_result(message="The input parameters are invalid.")
permission = req.get("permission") permission = req.get("permission")

4
sdk/python/test/test_frontend_api/common.py
View File

@ -68,7 +68,7 @@ def upload_file(auth, dataset_id, path):
def list_document(auth, dataset_id): def list_document(auth, dataset_id):
authorization = {"Authorization": auth} authorization = {"Authorization": auth}
url = f"{HOST_ADDRESS}/v1/document/list?kb_id={dataset_id}" url = f"{HOST_ADDRESS}/v1/document/list?kb_id={dataset_id}"
res = requests.get(url=url, headers=authorization) res = requests.get(url=url, headers=authorization)
return res.json() return res.json()
@ -85,7 +85,7 @@ def parse_docs(auth, doc_ids):
authorization = {"Authorization": auth} authorization = {"Authorization": auth}
json_req = { json_req = {
"doc_ids": doc_ids, "doc_ids": doc_ids,
"run": 1 "run": 1
} }
url = f"{HOST_ADDRESS}/v1/document/run" url = f"{HOST_ADDRESS}/v1/document/run"
res = requests.post(url=url, headers=authorization, json=json_req) res = requests.post(url=url, headers=authorization, json=json_req)

2
sdk/python/test/test_http_api/test_dataset_mangement/common.py
View File

@ -39,7 +39,7 @@ def list_dataset(auth, params=None):
def update_dataset(auth, dataset_id, payload): def update_dataset(auth, dataset_id, payload):
res = requests.put( res = requests.put(
url=f"{API_URL}/{dataset_id}", headers=HEADERS, auth=auth, json=payload url=f"{API_URL}/{dataset_id}", headers=HEADERS, auth=auth, json=payload
) )
return res.json() return res.json()