From 7fad48f42c454601ab770eebbdc63cf87972c21b Mon Sep 17 00:00:00 2001 From: Wang Date: Wed, 11 Sep 2024 09:32:12 +0800 Subject: [PATCH] fix: empty or contains only empty strings. (#2347) ### What problem does this PR solve? the setting was kept empty for Empty_response. In expectation, this case should get a response from the LLM if can't find the references from the knowledgebase. ### Type of change - [x] Bug Fix (non-breaking change which fixes an issue) ![image](https://github.com/user-attachments/assets/9c382b1d-40f6-43b0-848c-fa6863f9a253) ![image](https://github.com/user-attachments/assets/032d2001-97a2-4faa-91bf-c9c57caf2070) Co-authored-by: Theta Wang (ncu) --- agent/component/retrieval.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/agent/component/retrieval.py b/agent/component/retrieval.py index dbd087ee8..b6013506a 100644 --- a/agent/component/retrieval.py +++ b/agent/component/retrieval.py @@ -76,7 +76,8 @@ class Retrieval(ComponentBase, ABC): if not kbinfos["chunks"]: df = Retrieval.be_output("") - df["empty_response"] = self._param.empty_response + if self._param.empty_response and self._param.empty_response.strip(): + df["empty_response"] = self._param.empty_response return df df = pd.DataFrame(kbinfos["chunks"])