AI/ragflow
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/infiniflow/ragflow.git synced 2025-08-10 21:19:02 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix: don't modify S3 file name when not using prefix_path (#7152)

Browse Source 
### What problem does this PR solve?

Hello, I encountered a problem when trying to use a S3 backend
(seaweedfs) for storage in RAGFlow: when calling
`STORAGE_IMPL.get("bucket", "key")`, the actual request sent to S3 is
`bucket/bucket/key`, causing a `NoSuchKey` error.

I compared the code in `s3_conn.py` to `minio_conn.py` and
`oss_conn.py`, then decided to remove the `else` branch in
`use_prefix_path` method, and it works. I didn't configure `prefix_path`
or `bucket` in `s3` section of the `service_conf.yaml`.

I think this is a bug, but not sure.

### Type of change

- [x] Bug Fix (non-breaking change which fixes an issue)
- [ ] New Feature (non-breaking change which adds functionality)
- [ ] Documentation Update
- [ ] Refactoring
- [ ] Performance Improvement
- [ ] Other (please describe):
This commit is contained in:
Song Fuchang 2025-04-21 11:55:50 +08:00 committed by GitHub
parent 68b9dae6c0
commit 8362ab405c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 0 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
rag/utils/s3_conn.py
View File

@ -54,8 +54,6 @@ class RAGFlowS3:
# used as the file prefix. This is especially useful when you're using the default bucket # used as the file prefix. This is especially useful when you're using the default bucket
if self.prefix_path: if self.prefix_path:
fnm = f"{self.prefix_path}/{bucket}/{fnm}" fnm = f"{self.prefix_path}/{bucket}/{fnm}"
else:
fnm = f"{bucket}/{fnm}"
return method(self, bucket, fnm, *args, **kwargs) return method(self, bucket, fnm, *args, **kwargs)
return wrapper return wrapper