From c26c38ee1243a0b445e9d92772a1fb2d964935e7 Mon Sep 17 00:00:00 2001 From: liu an Date: Tue, 8 Apr 2025 18:53:02 +0800 Subject: [PATCH] Test: Added test cases for Delete Chat Assistants HTTP API (#6879) ### What problem does this PR solve? cover [delete chat assistants](https://ragflow.io/docs/dev/http_api_reference#delete-chat-assistants) endpoints ### Type of change - [x] add test cases --- sdk/python/test/test_http_api/common.py | 2 +- .../test_delete_chat_assistants.py | 123 ++++++++++++++++++ .../test_delete_datasets.py | 1 - 3 files changed, 124 insertions(+), 2 deletions(-) create mode 100644 sdk/python/test/test_http_api/test_chat_assistant_management/test_delete_chat_assistants.py diff --git a/sdk/python/test/test_http_api/common.py b/sdk/python/test/test_http_api/common.py index 0f6e5e9a..b0eca898 100644 --- a/sdk/python/test/test_http_api/common.py +++ b/sdk/python/test/test_http_api/common.py @@ -216,6 +216,6 @@ def delete_chat_assistants(auth, payload=None): def batch_create_chat_assistants(auth, num): chat_assistant_ids = [] for i in range(num): - res = create_chat_assistant(auth, {"name": f"test_chat_assistant_{i}"}) + res = create_chat_assistant(auth, {"name": f"test_chat_assistant_{i}", "dataset_ids": []}) chat_assistant_ids.append(res["data"]["id"]) return chat_assistant_ids diff --git a/sdk/python/test/test_http_api/test_chat_assistant_management/test_delete_chat_assistants.py b/sdk/python/test/test_http_api/test_chat_assistant_management/test_delete_chat_assistants.py new file mode 100644 index 00000000..efdbd340 --- /dev/null +++ b/sdk/python/test/test_http_api/test_chat_assistant_management/test_delete_chat_assistants.py @@ -0,0 +1,123 @@ +# +# Copyright 2025 The InfiniFlow Authors. All Rights Reserved. +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# +from concurrent.futures import ThreadPoolExecutor + +import pytest +from common import INVALID_API_TOKEN, batch_create_chat_assistants, delete_chat_assistants, list_chat_assistants +from libs.auth import RAGFlowHttpApiAuth + + +class TestAuthorization: + @pytest.mark.parametrize( + "auth, expected_code, expected_message", + [ + (None, 0, "`Authorization` can't be empty"), + ( + RAGFlowHttpApiAuth(INVALID_API_TOKEN), + 109, + "Authentication error: API key is invalid!", + ), + ], + ) + def test_invalid_auth(self, auth, expected_code, expected_message): + res = delete_chat_assistants(auth) + assert res["code"] == expected_code + assert res["message"] == expected_message + + +class TestChatAssistantsDelete: + @pytest.mark.parametrize( + "payload, expected_code, expected_message, remaining", + [ + (None, 0, "", 0), + ({"ids": []}, 0, "", 0), + ({"ids": ["invalid_id"]}, 102, "You don't own the chat invalid_id", 5), + ({"ids": ["\n!?。；！？\"'"]}, 102, "You don't own the chat \n!?。；！？\"'", 5), + ("not json", 100, "AttributeError(\"'str' object has no attribute 'get'\")", 5), + (lambda r: {"ids": r[:1]}, 0, "", 4), + (lambda r: {"ids": r}, 0, "", 0), + ], + ) + def test_basic_scenarios(self, get_http_api_auth, add_chat_assistants_func, payload, expected_code, expected_message, remaining): + _, _, _, chat_assistant_ids = add_chat_assistants_func + if callable(payload): + payload = payload(chat_assistant_ids) + res = delete_chat_assistants(get_http_api_auth, payload) + assert res["code"] == expected_code + if res["code"] != 0: + assert res["message"] == expected_message + + res = list_chat_assistants(get_http_api_auth) + assert len(res["data"]) == remaining + + @pytest.mark.skip(reason="issues/6875") + @pytest.mark.parametrize( + "payload", + [ + lambda r: {"ids": ["invalid_id"] + r}, + lambda r: {"ids": r[:1] + ["invalid_id"] + r[1:3]}, + lambda r: {"ids": r + ["invalid_id"]}, + ], + ) + def test_delete_partial_invalid_id(self, get_http_api_auth, add_chat_assistants_func, payload): + _, _, _, chat_assistant_ids = add_chat_assistants_func + if callable(payload): + payload = payload(chat_assistant_ids) + res = delete_chat_assistants(get_http_api_auth, payload) + assert res["code"] == 102 + assert res["message"] == "You don't own the chat invalid_id" + + res = list_chat_assistants(get_http_api_auth) + print(res) + assert len(res["data"]) == 0 + + def test_repeated_deletion(self, get_http_api_auth, add_chat_assistants_func): + _, _, _, chat_assistant_ids = add_chat_assistants_func + res = delete_chat_assistants(get_http_api_auth, {"ids": chat_assistant_ids}) + assert res["code"] == 0 + + res = delete_chat_assistants(get_http_api_auth, {"ids": chat_assistant_ids}) + assert res["code"] == 102 + assert "You don't own the chat" in res["message"] + + @pytest.mark.skip(reason="issues/6876") + def test_duplicate_deletion(self, get_http_api_auth, add_chat_assistants_func): + _, _, _, chat_assistant_ids = add_chat_assistants_func + res = delete_chat_assistants(get_http_api_auth, {"ids": chat_assistant_ids + chat_assistant_ids}) + print(res) + assert res["code"] == 0 + assert "Duplicate chat ids" in res["data"]["errors"][0] + assert res["data"]["success_count"] == 3 + + res = delete_chat_assistants(get_http_api_auth) + assert len(res["data"]) == 0 + + def test_concurrent_deletion(self, get_http_api_auth): + ids = batch_create_chat_assistants(get_http_api_auth, 100) + + with ThreadPoolExecutor(max_workers=5) as executor: + futures = [executor.submit(delete_chat_assistants, get_http_api_auth, {"ids": ids[i : i + 1]}) for i in range(100)] + responses = [f.result() for f in futures] + assert all(r["code"] == 0 for r in responses) + + @pytest.mark.slow + def test_delete_10k(self, get_http_api_auth): + ids = batch_create_chat_assistants(get_http_api_auth, 10_000) + res = delete_chat_assistants(get_http_api_auth, {"ids": ids}) + assert res["code"] == 0 + + res = list_chat_assistants(get_http_api_auth) + assert len(res["data"]) == 0 diff --git a/sdk/python/test/test_http_api/test_dataset_mangement/test_delete_datasets.py b/sdk/python/test/test_http_api/test_dataset_mangement/test_delete_datasets.py index cd9a92e4..389a9a11 100644 --- a/sdk/python/test/test_http_api/test_dataset_mangement/test_delete_datasets.py +++ b/sdk/python/test/test_http_api/test_dataset_mangement/test_delete_datasets.py @@ -13,7 +13,6 @@ # See the License for the specific language governing permissions and # limitations under the License. # - from concurrent.futures import ThreadPoolExecutor import pytest