From 55b954ffeb1c1b9af2c216b6552988602783306d Mon Sep 17 00:00:00 2001
From: Yanlong Wang <yanlong.wang@naiver.org>
Date: Tue, 30 Apr 2024 18:56:46 +0800
Subject: [PATCH] fix: tweak health check

---
 backend/functions/src/services/puppeteer.ts | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/backend/functions/src/services/puppeteer.ts b/backend/functions/src/services/puppeteer.ts
index d13c761..f35315c 100644
--- a/backend/functions/src/services/puppeteer.ts
+++ b/backend/functions/src/services/puppeteer.ts
@@ -151,21 +151,24 @@ export class PuppeteerControl extends AsyncService {
 
     @maxConcurrency(1)
     async healthCheck() {
-        const healthyPage = await Promise.race([this.pagePool.acquire(3), delay(60_000).then(() => null)]).catch((err) => {
-            this.logger.error(`Health check failed`, { err: marshalErrorLike(err) });
+        this.pagePool.max += 1;
+        const healthyPage = await this.pagePool.acquire(3).catch((err) => {
+            this.logger.warn(`Health check failed`, { err: marshalErrorLike(err) });
             return null;
         });
+        this.pagePool.max -= 1;
 
         if (healthyPage) {
             this.pagePool.release(healthyPage);
             return;
         }
 
-        this.logger.warn(`Health check failed, trying to clean up.`);
+        this.logger.warn(`Trying to clean up...`);
         await this.pagePool.clear();
         this.browser.process()?.kill('SIGKILL');
         Reflect.deleteProperty(this, 'browser');
         this.emit('crippled');
+        this.logger.warn(`Browser killed`);
     }
 
     async newPage() {