From c03aa5ffeb50e586da6f78231c9d3db59bc3d83c Mon Sep 17 00:00:00 2001
From: "zhou.xu" <zhou.xu@bambulab.com>
Date: Mon, 5 Aug 2024 10:05:40 +0800
Subject: [PATCH] FIX:fix crash opengl api in mac

jira: none
Change-Id: I797082987378f53480eacdc6a2528cfdedf50528
(cherry picked from commit 654db45bc293c03ec72cbbb7f4a651a7e946f9ea)
---
 src/slic3r/GUI/GLModel.cpp       | 30 ++++++++++++++++++------------
 src/slic3r/GUI/OpenGLManager.cpp |  1 +
 src/slic3r/GUI/PartPlate.cpp     |  1 +
 3 files changed, 20 insertions(+), 12 deletions(-)

diff --git a/src/slic3r/GUI/GLModel.cpp b/src/slic3r/GUI/GLModel.cpp
index d77ab7ef8..06fa16af6 100644
--- a/src/slic3r/GUI/GLModel.cpp
+++ b/src/slic3r/GUI/GLModel.cpp
@@ -916,23 +916,26 @@ void GLModel::create_or_update_mats_vbo(unsigned int &vbo, const std::vector<Sli
 
 void GLModel::bind_mats_vbo(unsigned int instance_mats_vbo, unsigned int instances_count, int location)
 {
+    if (instance_mats_vbo == 0 || instances_count == 0) {
+        return;
+    }
     auto one_mat_all_size = sizeof(float) * 16;
     auto one_mat_col_size = sizeof(float) * 4;
     glsafe(::glBindBuffer(GL_ARRAY_BUFFER, instance_mats_vbo));
     for (unsigned int i = 0; i < instances_count; i++) { // set attribute pointers for matrix (4 times vec4)
-        glEnableVertexAttribArray(location);
-        glVertexAttribPointer(location, 4, GL_FLOAT, GL_FALSE, one_mat_all_size, (void *) 0);
-        glEnableVertexAttribArray(location + 1);
-        glVertexAttribPointer(location + 1, 4, GL_FLOAT, GL_FALSE, one_mat_all_size, (void *) (one_mat_col_size));
-        glEnableVertexAttribArray(location + 2);
-        glVertexAttribPointer(location + 2, 4, GL_FLOAT, GL_FALSE, one_mat_all_size, (void *) (2 * one_mat_col_size));
-        glEnableVertexAttribArray(location + 3);
-        glVertexAttribPointer(location + 3, 4, GL_FLOAT, GL_FALSE, one_mat_all_size, (void *) (3 * one_mat_col_size));
+        glsafe(glEnableVertexAttribArray(location));
+        glsafe(glVertexAttribPointer(location, 4, GL_FLOAT, GL_FALSE, one_mat_all_size, (void *) 0));
+        glsafe(glEnableVertexAttribArray(location + 1));
+        glsafe(glVertexAttribPointer(location + 1, 4, GL_FLOAT, GL_FALSE, one_mat_all_size, (void *) (one_mat_col_size)));
+        glsafe(glEnableVertexAttribArray(location + 2));
+        glsafe(glVertexAttribPointer(location + 2, 4, GL_FLOAT, GL_FALSE, one_mat_all_size, (void *) (2 * one_mat_col_size)));
+        glsafe(glEnableVertexAttribArray(location + 3));
+        glsafe(glVertexAttribPointer(location + 3, 4, GL_FLOAT, GL_FALSE, one_mat_all_size, (void *) (3 * one_mat_col_size)));
         // Update the matrix every time after an object is drawn//useful
-        glVertexAttribDivisor(location, 1);
-        glVertexAttribDivisor(location + 1, 1);
-        glVertexAttribDivisor(location + 2, 1);
-        glVertexAttribDivisor(location + 3, 1);
+        glsafe(glVertexAttribDivisor(location, 1));
+        glsafe(glVertexAttribDivisor(location + 1, 1));
+        glsafe(glVertexAttribDivisor(location + 2, 1));
+        glsafe(glVertexAttribDivisor(location + 3, 1));
     }
 }
 
@@ -943,6 +946,9 @@ void GLModel::render_geometry_instance(unsigned int instance_mats_vbo, unsigned
 
 void GLModel::render_geometry_instance(unsigned int instance_mats_vbo, unsigned int instances_count, const std::pair<size_t, size_t> &range)
 {
+    if (instance_mats_vbo == 0 || instances_count == 0) {
+        return;
+    }
     if (m_render_data.size() != 1) { return; }
     GLShaderProgram *shader = wxGetApp().get_current_shader();
     if (shader == nullptr) return;
diff --git a/src/slic3r/GUI/OpenGLManager.cpp b/src/slic3r/GUI/OpenGLManager.cpp
index 3f38e15bc..4c0577407 100644
--- a/src/slic3r/GUI/OpenGLManager.cpp
+++ b/src/slic3r/GUI/OpenGLManager.cpp
@@ -236,6 +236,7 @@ OpenGLManager::~OpenGLManager()
 bool OpenGLManager::init_gl(bool popup_error)
 {
     if (!m_gl_initialized) {
+        glewExperimental = GL_TRUE;
         GLenum result = glewInit();
         if (result != GLEW_OK) {
             BOOST_LOG_TRIVIAL(error) << "Unable to init glew library";
diff --git a/src/slic3r/GUI/PartPlate.cpp b/src/slic3r/GUI/PartPlate.cpp
index 2a6ff4511..1fb861a2a 100644
--- a/src/slic3r/GUI/PartPlate.cpp
+++ b/src/slic3r/GUI/PartPlate.cpp
@@ -4766,6 +4766,7 @@ void PartPlateList::render_instance_grid(bool bottom)
 
 void PartPlateList::render_instance_background(bool force_default_color)
 {
+    if (m_unselected_plate_trans.size() == 0) { return; }
     // draw background
     ColorRGBA color;
     if (!force_default_color) {