GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-08-12 22:39:07 +08:00
Code Issues Packages Projects Releases Wiki Activity

Don't modify list you're iterating over

Browse Source 
It doesn't give a problem right now since we're only iterating over lists of length 1 here, but in the future this could cause weird bugs.

Contributes to issue CURA-2822.
This commit is contained in:
Ghostkeeper 2017-06-29 15:09:50 +02:00
parent 8ae49c317c
commit 034686e9fa
No known key found for this signature in database
GPG Key ID: C5F96EE2BC0F7E75
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cura/Settings/ContainerManager.py
View File

@ -224,7 +224,7 @@ class ContainerManager(QObject):
root = container.getMetaDataEntry(root_name) root = container.getMetaDataEntry(root_name)
item = root item = root
for entry in entries: for _ in range(len(entries)):
item = item.get(entries.pop(0), { }) item = item.get(entries.pop(0), { })
if item[entry_name] != entry_value: if item[entry_name] != entry_value: