From 94314a7c2cbb4abc9e2c924fb06be092d7028091 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Mon, 29 Feb 2016 15:09:51 +0100 Subject: [PATCH 1/2] Make infill overlap depend on line width Paul said this way was a better default for all our profiles. Contributes to issue CURA-892. --- resources/machines/fdmprinter.json | 2 +- resources/profiles/ultimaker2+/pla_0.25_normal.curaprofile | 1 - resources/profiles/ultimaker2+/pla_0.4_fast.curaprofile | 1 - resources/profiles/ultimaker2+/pla_0.4_high.curaprofile | 1 - resources/profiles/ultimaker2+/pla_0.4_normal.curaprofile | 1 - resources/profiles/ultimaker2+/pla_0.4_ulti.curaprofile | 1 - resources/profiles/ultimaker2+/pla_0.6_normal.curaprofile | 1 - resources/profiles/ultimaker2+/pla_0.8_normal.curaprofile | 1 - 8 files changed, 1 insertion(+), 8 deletions(-) diff --git a/resources/machines/fdmprinter.json b/resources/machines/fdmprinter.json index b90fd5348a..12b484d961 100644 --- a/resources/machines/fdmprinter.json +++ b/resources/machines/fdmprinter.json @@ -588,7 +588,7 @@ "default": 10, "min_value": "0", "max_value_warning": "100", - "inherit_function": "10 if infill_sparse_density < 95 else 0", + "inherit_function": "wall_line_width * 0.1", "visible": false }, "infill_wipe_dist": { diff --git a/resources/profiles/ultimaker2+/pla_0.25_normal.curaprofile b/resources/profiles/ultimaker2+/pla_0.25_normal.curaprofile index 6ef1b1b74b..069f964e4d 100644 --- a/resources/profiles/ultimaker2+/pla_0.25_normal.curaprofile +++ b/resources/profiles/ultimaker2+/pla_0.25_normal.curaprofile @@ -15,7 +15,6 @@ travel_compensate_overlapping_walls_enabled = True skin_no_small_gaps_heuristic = False top_bottom_pattern = lines infill_sparse_density = 22 -infill_overlap = 0.022 infill_wipe_dist = 0.1 retraction_amount = 6 retraction_min_travel = 0.5 diff --git a/resources/profiles/ultimaker2+/pla_0.4_fast.curaprofile b/resources/profiles/ultimaker2+/pla_0.4_fast.curaprofile index 928355e936..870f8da6ed 100644 --- a/resources/profiles/ultimaker2+/pla_0.4_fast.curaprofile +++ b/resources/profiles/ultimaker2+/pla_0.4_fast.curaprofile @@ -15,7 +15,6 @@ travel_compensate_overlapping_walls_enabled = True skin_no_small_gaps_heuristic = False top_bottom_pattern = lines infill_sparse_density = 18 -infill_overlap = 0.035 infill_wipe_dist = 0.2 retraction_amount = 5.5 retraction_min_travel = 0.5 diff --git a/resources/profiles/ultimaker2+/pla_0.4_high.curaprofile b/resources/profiles/ultimaker2+/pla_0.4_high.curaprofile index 4fe6278913..a2a89d897f 100644 --- a/resources/profiles/ultimaker2+/pla_0.4_high.curaprofile +++ b/resources/profiles/ultimaker2+/pla_0.4_high.curaprofile @@ -15,7 +15,6 @@ travel_compensate_overlapping_walls_enabled = True skin_no_small_gaps_heuristic = False top_bottom_pattern = lines infill_sparse_density = 22 -infill_overlap = 0.035 infill_wipe_dist = 0.2 retraction_amount = 5.5 retraction_min_travel = 0.5 diff --git a/resources/profiles/ultimaker2+/pla_0.4_normal.curaprofile b/resources/profiles/ultimaker2+/pla_0.4_normal.curaprofile index 8dd527ba73..54dedd578d 100644 --- a/resources/profiles/ultimaker2+/pla_0.4_normal.curaprofile +++ b/resources/profiles/ultimaker2+/pla_0.4_normal.curaprofile @@ -15,7 +15,6 @@ travel_compensate_overlapping_walls_enabled = True skin_no_small_gaps_heuristic = False top_bottom_pattern = lines infill_sparse_density = 20 -infill_overlap = 0.035 infill_wipe_dist = 0.2 retraction_amount = 5.5 retraction_min_travel = 0.5 diff --git a/resources/profiles/ultimaker2+/pla_0.4_ulti.curaprofile b/resources/profiles/ultimaker2+/pla_0.4_ulti.curaprofile index 611c416bdc..eccc14ecff 100644 --- a/resources/profiles/ultimaker2+/pla_0.4_ulti.curaprofile +++ b/resources/profiles/ultimaker2+/pla_0.4_ulti.curaprofile @@ -15,7 +15,6 @@ travel_compensate_overlapping_walls_enabled = True skin_no_small_gaps_heuristic = False top_bottom_pattern = lines infill_sparse_density = 25 -infill_overlap = 0.035 infill_wipe_dist = 0.2 retraction_amount = 5.5 retraction_min_travel = 0.5 diff --git a/resources/profiles/ultimaker2+/pla_0.6_normal.curaprofile b/resources/profiles/ultimaker2+/pla_0.6_normal.curaprofile index 3257c79446..6a5f4033b1 100644 --- a/resources/profiles/ultimaker2+/pla_0.6_normal.curaprofile +++ b/resources/profiles/ultimaker2+/pla_0.6_normal.curaprofile @@ -15,7 +15,6 @@ travel_compensate_overlapping_walls_enabled = True skin_no_small_gaps_heuristic = False top_bottom_pattern = lines infill_sparse_density = 20 -infill_overlap = 0.053 infill_wipe_dist = 0.3 retraction_amount = 6 retraction_min_travel = 0.5 diff --git a/resources/profiles/ultimaker2+/pla_0.8_normal.curaprofile b/resources/profiles/ultimaker2+/pla_0.8_normal.curaprofile index 936c46b742..fe454b5c32 100644 --- a/resources/profiles/ultimaker2+/pla_0.8_normal.curaprofile +++ b/resources/profiles/ultimaker2+/pla_0.8_normal.curaprofile @@ -15,7 +15,6 @@ travel_compensate_overlapping_walls_enabled = True skin_no_small_gaps_heuristic = False top_bottom_pattern = lines infill_sparse_density = 20 -infill_overlap = 0.07 infill_wipe_dist = 0.4 retraction_amount = 6 retraction_min_travel = 0.5 From b9786e5208383874db1212666eb89fbfced952a0 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Mon, 29 Feb 2016 15:38:33 +0100 Subject: [PATCH 2/2] Fix for infill overlap Turns out it was only a distance on the master branch and should still be a percentage on 2.1. Sorry! The dependency on infill density still remains superfluous though. Contributes to issue CURA-892. --- resources/machines/fdmprinter.json | 1 - 1 file changed, 1 deletion(-) diff --git a/resources/machines/fdmprinter.json b/resources/machines/fdmprinter.json index 12b484d961..cabb19745d 100644 --- a/resources/machines/fdmprinter.json +++ b/resources/machines/fdmprinter.json @@ -588,7 +588,6 @@ "default": 10, "min_value": "0", "max_value_warning": "100", - "inherit_function": "wall_line_width * 0.1", "visible": false }, "infill_wipe_dist": {