GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-08-13 11:39:03 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix HttpNetworkManager not providing error parameter if there is no error

Browse Source 
Contributes to issue CURA-8609.
This commit is contained in:
Ghostkeeper 2021-10-15 16:00:54 +02:00
parent f56e438747
commit 0583814dfa
No known key found for this signature in database
GPG Key ID: D2A8871EE34EC59A
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
cura/PrinterOutput/UploadMaterialsJob.py
View File

@ -121,13 +121,12 @@ class UploadMaterialsJob(Job):
scope = self._scope
)
def onUploadRequestCompleted(self, reply: "QNetworkReply", error: Optional["QNetworkReply.NetworkError"]) -> None:
def onUploadRequestCompleted(self, reply: "QNetworkReply") -> None:
"""
Triggered when we successfully requested to upload a material archive.
We then need to start uploading the material archive to the URL that the request answered with.
:param reply: The reply from the server to our request to upload an archive.
:param error: An error code (Qt enum) if the request failed. Failure is handled by `onError` though.
"""
response_data = HttpRequestManager.readJSON(reply)
if response_data is None:
@ -161,12 +160,11 @@ class UploadMaterialsJob(Job):
scope = self._scope
)
def onUploadCompleted(self, reply: "QNetworkReply", error: Optional["QNetworkReply.NetworkError"]) -> None:
def onUploadCompleted(self, reply: "QNetworkReply") -> None:
"""
When we've successfully uploaded the archive to the cloud, we need to notify the API to start syncing that
archive to every printer.
:param reply: The reply from the cloud storage when the upload succeeded.
:param error: An error message if the upload failed. Errors are handled by the `onError` function though.
"""
for container_stack in self._printer_metadata:
cluster_id = container_stack["um_cloud_cluster_id"]
@ -180,7 +178,7 @@ class UploadMaterialsJob(Job):
scope = self._scope
)
def onUploadConfirmed(self, printer_id: str, reply: "QNetworkReply", error: Optional["QNetworkReply.NetworkError"]) -> None:
def onUploadConfirmed(self, printer_id: str, reply: "QNetworkReply", error: Optional["QNetworkReply.NetworkError"] = None) -> None:
"""
Triggered when we've got a confirmation that the material is synced with the printer, or that syncing failed.