GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-04-20 20:59:48 +08:00
Code Issues Packages Projects Releases Wiki Activity

Implement Review comments

Browse Source 
CURA-5479
This commit is contained in:
Nino van Hooff 2020-07-01 16:47:20 +02:00
parent 24820bab07
commit 06284b6a73
3 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
cura/UI/PrintInformation.py
View File

@ -254,8 +254,7 @@ class PrintInformation(QObject):
def _onPreferencesChanged(self, preference: str) -> None:
if preference == "cura/job_name_template":
self._updateJobName()
if preference == "cura/material_settings":
elif preference == "cura/material_settings":
for build_plate_number in range(self._multi_build_plate_model.maxBuildPlate + 1):
self._calculateInformation(build_plate_number)

6
resources/qml/Preferences/GeneralPage.qml
View File

@ -642,7 +642,7 @@ UM.PreferencesPage
TextField
{
id: jobNameTemplateTextField
width: 200 * screenScaleFactor
width: 250 * screenScaleFactor
text: UM.Preferences.getValue("cura/job_name_template")
onTextChanged: UM.Preferences.setValue("cura/job_name_template", text)
}
@ -681,7 +681,7 @@ UM.PreferencesPage
ComboBox
{
id: choiceOnOpenProjectDropDownButton
width: 200 * screenScaleFactor
width: 250 * screenScaleFactor
model: ListModel
{
@ -747,7 +747,7 @@ UM.PreferencesPage
ComboBox
{
id: choiceOnProfileOverrideDropDownButton
width: 200 * screenScaleFactor
width: 250 * screenScaleFactor
model: ListModel
{

2
tests/TestPrintInformation.py
View File

@ -26,7 +26,7 @@ def getPrintInformation(printer_name) -> PrintInformation:
mocked_extruder_stack.material = mocked_material
mock_application.getInstance = MagicMock(return_value = mock_application)
mocked_preferences.getValue = MagicMock(side_effect=preferencesGetValue)
mocked_preferences.getValue = MagicMock(side_effect = preferencesGetValue)
global_container_stack = MagicMock()
global_container_stack.definition.getName = MagicMock(return_value = printer_name)