From 07e9237d7202c835439156cff650c0295b33d469 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Wed, 17 Nov 2021 14:23:26 +0100 Subject: [PATCH] Add missing action for button CURA-8561 --- plugins/Marketplace/PackageModel.py | 1 - plugins/Marketplace/resources/qml/PackageCard.qml | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/plugins/Marketplace/PackageModel.py b/plugins/Marketplace/PackageModel.py index 0e73cac3b7..f87a30e0b7 100644 --- a/plugins/Marketplace/PackageModel.py +++ b/plugins/Marketplace/PackageModel.py @@ -27,7 +27,6 @@ class PackageModel(QObject): """ super().__init__(parent) self._package_id = package_data.get("package_id", "UnknownPackageId") - self._icon_url = package_data.get("icon_url", "") self._display_name = package_data.get("display_name", catalog.i18nc("@label:property", "Unknown Package")) self._is_verified = "verified" in package_data.get("tags", []) diff --git a/plugins/Marketplace/resources/qml/PackageCard.qml b/plugins/Marketplace/resources/qml/PackageCard.qml index 69b1639cc8..56b3519360 100644 --- a/plugins/Marketplace/resources/qml/PackageCard.qml +++ b/plugins/Marketplace/resources/qml/PackageCard.qml @@ -170,6 +170,7 @@ Rectangle color: externalLinkButton.hovered ? UM.Theme.getColor("action_button_hovered"): "transparent" radius: externalLinkButton.width / 2 } + onClicked: Qt.openUrlExternally(packageData.authorInfoUrl) } } @@ -245,7 +246,6 @@ Rectangle textFont: descriptionLabel.font isIconOnRightSide: true - // NOTE: Is this the right URL for this action? onClicked: Qt.openUrlExternally(packageData.packageInfoUrl) } }