From 097cc72d89882b0bb05fb2627f91f5d36dbf7042 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Mon, 11 Dec 2017 09:44:56 +0100 Subject: [PATCH] Document why we're only returning full profiles It's a limitation of the quality manager that would require major refactoring there to fix. Contributes to issue CURA-4243. --- cura/Settings/ProfilesModel.py | 2 +- cura/Settings/QualityAndUserProfilesModel.py | 2 +- cura/Settings/UserProfilesModel.py | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/cura/Settings/ProfilesModel.py b/cura/Settings/ProfilesModel.py index b32776f465..849d6959b9 100644 --- a/cura/Settings/ProfilesModel.py +++ b/cura/Settings/ProfilesModel.py @@ -87,7 +87,7 @@ class ProfilesModel(InstanceContainersModel): not_supported_container = ContainerRegistry.getInstance().findContainers(id = "empty_quality")[0] result.append(not_supported_container) - return {item.getId():item for item in result}, {} + return {item.getId():item for item in result}, {} #Only return true profiles for now, no metadata. The quality manager is not able to get only metadata yet. ## Re-computes the items in this model, and adds the layer height role. def _recomputeItems(self): diff --git a/cura/Settings/QualityAndUserProfilesModel.py b/cura/Settings/QualityAndUserProfilesModel.py index 8d47f1d4ab..bc81df976b 100644 --- a/cura/Settings/QualityAndUserProfilesModel.py +++ b/cura/Settings/QualityAndUserProfilesModel.py @@ -43,4 +43,4 @@ class QualityAndUserProfilesModel(ProfilesModel): result = filtered_quality_changes result.update({q.getId():q for q in quality_list}) - return result, {} + return result, {} #Only return true profiles for now, no metadata. The quality manager is not able to get only metadata yet. \ No newline at end of file diff --git a/cura/Settings/UserProfilesModel.py b/cura/Settings/UserProfilesModel.py index f69c0ff7d1..e093c6c132 100644 --- a/cura/Settings/UserProfilesModel.py +++ b/cura/Settings/UserProfilesModel.py @@ -52,7 +52,7 @@ class UserProfilesModel(ProfilesModel): (qc.getMetaDataEntry("extruder") == active_extruder.definition.getMetaDataEntry("quality_definition") or qc.getMetaDataEntry("extruder") == active_extruder.definition.getId())} - return filtered_quality_changes, {} + return filtered_quality_changes, {} #Only return true profiles for now, no metadata. The quality manager is not able to get only metadata yet. ## Called when a container changed on an extruder stack. #