From 0c0871656b70c284fdee96cdf7df77d0505f6a21 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Thu, 18 Aug 2016 17:26:51 +0200 Subject: [PATCH] Cache container registry before for loop Slight performance increase. We should pay more attention to this kind of thing. Contributes to issue CURA-2006. --- cura/Settings/ContainerManager.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/cura/Settings/ContainerManager.py b/cura/Settings/ContainerManager.py index a86e3d922c..3dbd179700 100644 --- a/cura/Settings/ContainerManager.py +++ b/cura/Settings/ContainerManager.py @@ -472,9 +472,10 @@ class ContainerManager(QObject): new_name = UM.Settings.ContainerRegistry.getInstance().uniqueName(new_name) + container_registry = UM.Settings.ContainerRegistry.getInstance() for container in self._getFilteredContainers(name = quality_name, type = "quality_changes"): stack_id = container.getMetaDataEntry("extruder", global_stack.getId()) - UM.Settings.ContainerRegistry.getInstance().renameContainer(container.getId(), new_name, self._createUniqueId(stack_id, new_name)) + container_registry.renameContainer(container.getId(), new_name, self._createUniqueId(stack_id, new_name)) UM.Application.getInstance().getMachineManager().activeQualityChanged.emit() return True