From 0ccf45731462678224b85908aff99294fcbf7a07 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Fri, 28 Feb 2020 14:25:50 +0100 Subject: [PATCH] Split up an overly long call into shorter readable bits --- cura/Settings/MachineManager.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/cura/Settings/MachineManager.py b/cura/Settings/MachineManager.py index 25152b3d5b..9bbf95a996 100755 --- a/cura/Settings/MachineManager.py +++ b/cura/Settings/MachineManager.py @@ -1507,7 +1507,13 @@ class MachineManager(QObject): if quality_id == empty_quality_container.getId(): extruder.intent = empty_intent_container continue - quality_node = container_tree.machines[definition_id].variants[variant_name].materials[material_base_file].qualities[quality_id] + + # Yes, we can find this in a single line of code. This makes it easier to read and it has the benefit + # that it doesn't lump key errors together for the crashlogs + machine_node = container_tree.machines[definition_id] + variant_node = machine_node.variants[variant_name] + material_node = variant_node.materials[material_base_file] + quality_node = material_node.qualities[quality_id] for intent_node in quality_node.intents.values(): if intent_node.intent_category == intent_category: # Found an intent with the correct category.