From e0b6679b91a70ea83478becb6b32c58ae33ffc18 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Wed, 19 Oct 2016 18:14:03 +0200 Subject: [PATCH 1/3] JSON feat: infill_hollow (CURA-2748) --- resources/definitions/fdmprinter.def.json | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index da3dfc56ba..fb0e260570 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -940,6 +940,14 @@ "type": "category", "children": { + "infill_hollow": + { + "label": "Hollow out object", + "description": "Remove all infill and make the inside of the object eligible for support.", + "type": "bool", + "default_value": false, + "settable_per_mesh": true + }, "infill_sparse_density": { "label": "Infill Density", From bce6a6fed45ff9efd46bf6931976122a4328efd8 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Tue, 1 Nov 2016 11:06:56 +0100 Subject: [PATCH 2/3] refactor: move infill_hollow to experimental category (CURA-2748) --- resources/definitions/fdmprinter.def.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index cc76c94440..4145a8986e 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -940,14 +940,6 @@ "type": "category", "children": { - "infill_hollow": - { - "label": "Hollow out object", - "description": "Remove all infill and make the inside of the object eligible for support.", - "type": "bool", - "default_value": false, - "settable_per_mesh": true - }, "infill_sparse_density": { "label": "Infill Density", @@ -3910,6 +3902,14 @@ "limit_to_extruder": "support_infill_extruder_nr", "settable_per_mesh": true }, + "infill_hollow": + { + "label": "Hollow out Objects", + "description": "Remove all infill and make the inside of the object eligible for support.", + "type": "bool", + "default_value": false, + "settable_per_mesh": true + }, "magic_fuzzy_skin_enabled": { "label": "Fuzzy Skin", From 24f78a7ee61a0ec6be150108425029cbd47c1d3e Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Tue, 1 Nov 2016 16:31:42 +0100 Subject: [PATCH 3/3] Capitalise setting name for Hollow Objects This is in line with other setting names. Contributes to issue CURA-2748. --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 4145a8986e..6cd06ffb8a 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -3904,7 +3904,7 @@ }, "infill_hollow": { - "label": "Hollow out Objects", + "label": "Hollow Out Objects", "description": "Remove all infill and make the inside of the object eligible for support.", "type": "bool", "default_value": false,