From 13eaa14752e7aec9d495c48bebe3be1206b56387 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Tue, 2 Oct 2018 11:37:04 +0200 Subject: [PATCH] Set preference for sending info to default state instead of removing them CURA-5095 --- .../VersionUpgrade34to35/VersionUpgrade34to35.py | 4 ++-- .../VersionUpgrade34to35/tests/TestVersionUpgrade34to35.py | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/plugins/VersionUpgrade/VersionUpgrade34to35/VersionUpgrade34to35.py b/plugins/VersionUpgrade/VersionUpgrade34to35/VersionUpgrade34to35.py index 7acea7ab5e..9d59133036 100644 --- a/plugins/VersionUpgrade/VersionUpgrade34to35/VersionUpgrade34to35.py +++ b/plugins/VersionUpgrade/VersionUpgrade34to35/VersionUpgrade34to35.py @@ -88,9 +88,9 @@ class VersionUpgrade34to35(VersionUpgrade): # Need to show the data collection agreement again because the data Cura collects has been changed. if parser.has_option("info", "asked_send_slice_info"): - parser.remove_option("info", "asked_send_slice_info") + parser.set("info", "asked_send_slice_info", "False") if parser.has_option("info", "send_slice_info"): - parser.remove_option("info", "send_slice_info") + parser.set("info", "send_slice_info", "True") # Update version number. parser["general"]["version"] = "6" diff --git a/plugins/VersionUpgrade/VersionUpgrade34to35/tests/TestVersionUpgrade34to35.py b/plugins/VersionUpgrade/VersionUpgrade34to35/tests/TestVersionUpgrade34to35.py index a109d97dd7..b74e6f35ac 100644 --- a/plugins/VersionUpgrade/VersionUpgrade34to35/tests/TestVersionUpgrade34to35.py +++ b/plugins/VersionUpgrade/VersionUpgrade34to35/tests/TestVersionUpgrade34to35.py @@ -38,6 +38,6 @@ def test_upgradeVersionNr(test_name, file_data, upgrader): assert parser["general"]["version"] == "6" assert parser["metadata"]["setting_version"] == "5" - # Check if the data collection values have been removed - assert not parser.has_option("info", "asked_send_slice_info") - assert not parser.has_option("info", "send_slice_info") + # Check if the data collection values have been reset to their defaults + assert parser.get("info", "asked_send_slice_info") == "False" + assert parser.get("info", "send_slice_info") == "True"