GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-05-21 20:19:32 +08:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source 
CURA-8762

Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
This commit is contained in:
Jaime van Kessel 2022-02-24 13:26:28 +01:00 committed by GitHub
parent df9d2d85c4
commit 19e43e8b66
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/Marketplace/resources/qml/PackageCardHeader.qml
View File

@ -36,19 +36,16 @@ Item
sourceSize.width: width sourceSize.width: width
source: source:
{ {
if(packageData.iconUrl != "") if (packageData.iconUrl != "")
{ {
return packageData.iconUrl return packageData.iconUrl
} }
if(packageData.packageType == "plugin") switch (packageData.packageType)
{ {
return "../images/Plugin.svg" case "plugin": return "../images/Plugin.svg";
case "material": return "../images/Spool.svg";
default: return "../images/placeholder.svg";
} }
if(packageData.packageType == "material")
{
return "../images/Spool.svg"
}
return "../images/placeholder.svg"
} }
} }

2
plugins/Marketplace/resources/qml/Packages.qml
View File

@ -84,7 +84,7 @@ ListView
manageableInListView: packages.packagesManageableInListView manageableInListView: packages.packagesManageableInListView
packageData: model.package packageData: model.package
width: { width: {
if(verticalScrollBar.visible) if (verticalScrollBar.visible)
{ {
return parent.width - UM.Theme.getSize("default_margin").width - UM.Theme.getSize("default_margin").width return parent.width - UM.Theme.getSize("default_margin").width - UM.Theme.getSize("default_margin").width
} }