From 7f6a89e6aa97d5d7c61d470298b16ef00d59e179 Mon Sep 17 00:00:00 2001 From: Ian Paschal Date: Wed, 21 Mar 2018 09:52:03 +0100 Subject: [PATCH 1/2] Fixed bug that didn't do anything Sometimes `None` was in the grouped objects which threw an error when trying to use `.callDecoration("isGroup")` on it. Nothing seems to break before, apart from the error message, and nothing breaks now either. But no error message. So that's good. --- plugins/CuraEngineBackend/StartSliceJob.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/CuraEngineBackend/StartSliceJob.py b/plugins/CuraEngineBackend/StartSliceJob.py index 89f9a144b0..0297a34385 100644 --- a/plugins/CuraEngineBackend/StartSliceJob.py +++ b/plugins/CuraEngineBackend/StartSliceJob.py @@ -239,7 +239,7 @@ class StartSliceJob(Job): for group in filtered_object_groups: group_message = self._slice_message.addRepeatedMessage("object_lists") - if group[0].getParent().callDecoration("isGroup"): + if group[0].getParent() is not None and group[0].getParent().callDecoration("isGroup"): self._handlePerObjectSettings(group[0].getParent(), group_message) for object in group: mesh_data = object.getMeshData() From 46e53ff0c3bef0413b25cc4681193b47dc1b3455 Mon Sep 17 00:00:00 2001 From: Mark Date: Wed, 21 Mar 2018 10:26:23 +0100 Subject: [PATCH 2/2] Clarify text CURA-4833 --- cura/CrashHandler.py | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/cura/CrashHandler.py b/cura/CrashHandler.py index c082578218..f51174aec0 100644 --- a/cura/CrashHandler.py +++ b/cura/CrashHandler.py @@ -85,14 +85,14 @@ class CrashHandler: dialog = QDialog() dialog.setMinimumWidth(500) dialog.setMinimumHeight(170) - dialog.setWindowTitle(catalog.i18nc("@title:window", "Cura Crashed")) + dialog.setWindowTitle(catalog.i18nc("@title:window", "Cura can't startup")) dialog.finished.connect(self._closeEarlyCrashDialog) layout = QVBoxLayout(dialog) label = QLabel() - label.setText(catalog.i18nc("@label crash message", """

A fatal error has occurred.

-

Unfortunately, Cura encountered an unrecoverable error during start up. It was possibly caused by some incorrect configuration files. We suggest to backup and reset your configuration.

+ label.setText(catalog.i18nc("@label crash message", """

Oops, Ultimaker Cura has encountered something that doesn't seem right.

+

We encountered an unrecoverable error during start up. It was possibly caused by some incorrect configuration files. We suggest to backup and reset your configuration.

Backups can be found in the configuration folder.

Please send us this Crash Report to fix the problem.

""")) @@ -220,7 +220,7 @@ class CrashHandler: def _messageWidget(self): label = QLabel() - label.setText(catalog.i18nc("@label crash message", """

A fatal error has occurred. Please send us this Crash Report to fix the problem

+ label.setText(catalog.i18nc("@label crash message", """

A fatal error has occurred in Cura. Please send us this Crash Report to fix the problem

Please use the "Send report" button to post a bug report automatically to our servers

"""))