From 8c25a91e029af914148fcbe3936c522e5486a395 Mon Sep 17 00:00:00 2001 From: Simon Edwards Date: Mon, 31 Oct 2016 11:45:59 +0100 Subject: [PATCH 1/3] Added a comment to help provide some kind of explaination for this magic value. CURA-2845 Prints are slightly oversized --- resources/definitions/ultimaker3.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/ultimaker3.def.json b/resources/definitions/ultimaker3.def.json index ff3c7eb943..26b3a8495a 100644 --- a/resources/definitions/ultimaker3.def.json +++ b/resources/definitions/ultimaker3.def.json @@ -155,6 +155,6 @@ "wall_0_inset": { "value": "0" }, "wall_line_width_x": { "value": "round(line_width * 0.3 / 0.35, 2)" }, "wall_thickness": { "value": "1" }, - "xy_offset": { "value": "-0.14" } + "xy_offset": { "value": "-0.14", "comment": "This is a hack to compensate for oversized prints. CURA-2845" } } } From 9a8a5db06ef4f79a9335ed960831bb7770f04a73 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Mon, 31 Oct 2016 12:41:29 +0100 Subject: [PATCH 2/3] Fix documentation for getAllExtruderSettings Didn't complete it previously. Oops. Contributes to issue CURA-2823. --- cura/Settings/ExtruderManager.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/cura/Settings/ExtruderManager.py b/cura/Settings/ExtruderManager.py index b127f6575d..0ade958f86 100644 --- a/cura/Settings/ExtruderManager.py +++ b/cura/Settings/ExtruderManager.py @@ -270,7 +270,10 @@ class ExtruderManager(QObject): def getAllExtruderValues(self, setting_key): return self.getAllExtruderSettings(setting_key, "value") - ## Gets a + ## Gets a property of a setting for all extruders. + # + # \param setting_key The setting to get the property of. + # \param property The property to get. def getAllExtruderSettings(self, setting_key, property): global_container_stack = UM.Application.getInstance().getGlobalContainerStack() if global_container_stack.getProperty("machine_extruder_count", "value") <= 1: From e74953c8bccee32210427bed3327e7faedc2388c Mon Sep 17 00:00:00 2001 From: Simon Edwards Date: Mon, 31 Oct 2016 13:27:22 +0100 Subject: [PATCH 3/3] Internal docs. CURA-2823 Maximum build volume not met despite disabled settings --- cura/Settings/ExtruderManager.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/cura/Settings/ExtruderManager.py b/cura/Settings/ExtruderManager.py index 0ade958f86..d3005a78fe 100644 --- a/cura/Settings/ExtruderManager.py +++ b/cura/Settings/ExtruderManager.py @@ -272,8 +272,9 @@ class ExtruderManager(QObject): ## Gets a property of a setting for all extruders. # - # \param setting_key The setting to get the property of. - # \param property The property to get. + # \param setting_key \type{str} The setting to get the property of. + # \param property \type{str} The property to get. + # \return \type{List} the list of results def getAllExtruderSettings(self, setting_key, property): global_container_stack = UM.Application.getInstance().getGlobalContainerStack() if global_container_stack.getProperty("machine_extruder_count", "value") <= 1: