From 20c43a4f13b0ff68140210946ad47fa678623e88 Mon Sep 17 00:00:00 2001 From: Jelle Spijker Date: Fri, 6 Jan 2023 13:12:02 +0100 Subject: [PATCH] compare against string type --- .github/workflows/cura-installer.yml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/cura-installer.yml b/.github/workflows/cura-installer.yml index f507a59e7d..940bfe7e35 100644 --- a/.github/workflows/cura-installer.yml +++ b/.github/workflows/cura-installer.yml @@ -240,19 +240,19 @@ jobs: working-directory: dist - name: Create the Windows exe installer (Powershell) - if: ${{ github.event.inputs.installer == 'true' && runner.os == 'Windows' && github.event.inputs.msi }} + if: ${{ github.event.inputs.installer == 'true' && runner.os == 'Windows' && github.event.inputs.msi == 'false' }} run: | python ..\cura_inst\packaging\NSIS\create_windows_installer.py ../cura_inst . "UltiMaker-Cura-$Env:CURA_VERSION_FULL-${{ inputs.os_name }}.exe" working-directory: dist - name: Create the Windows msi installer (Powershell) - if: ${{ github.event.inputs.installer == 'true' && runner.os == 'Windows' && github.event.inputs.msi }} + if: ${{ github.event.inputs.installer == 'true' && runner.os == 'Windows' && github.event.inputs.msi == 'true' }} run: | python ..\cura_inst\packaging\msi\create_windows_msi.py ..\cura_inst .\UltiMaker-Cura "UltiMaker-Cura-$Env:CURA_VERSION_FULL-${{ inputs.os_name }}.msi" "$Env:CURA_APP_NAME" working-directory: dist - name: Sign the Windows exe installer (Powershell) - if: ${{ github.event.inputs.installer == 'true' && runner.os == 'Windows' && github.event.inputs.msi }} + if: ${{ github.event.inputs.installer == 'true' && runner.os == 'Windows' &&github.event.inputs.msi == 'false' }} env: PFX_PATH: ${{ steps.create-pfx.outputs.PFX_PATH }} run: | @@ -260,7 +260,7 @@ jobs: working-directory: dist - name: Sign the Windows msi installer (Powershell) - if: ${{ github.event.inputs.installer == 'true' && runner.os == 'Windows' && github.event.inputs.msi }} + if: ${{ github.event.inputs.installer == 'true' && runner.os == 'Windows' && github.event.inputs.msi == 'true' }} env: PFX_PATH: ${{ steps.create-pfx.outputs.PFX_PATH }} run: |