From 40932a3ad212e87529abcaa8a34328b33abd7072 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Thu, 28 Jul 2016 13:07:14 +0200 Subject: [PATCH 1/3] Set default of draft shield height to 10mm This is a fairly arbitrary default until we have tests from materials. The draft shield height is now only used by the engine if the draft shield is enabled and limited. Contributes to issue CURA-1295. --- resources/definitions/fdmprinter.def.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 2df6c295a4..669d0bcef2 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -3346,8 +3346,8 @@ "type": "float", "minimum_value": "0", "maximum_value_warning": "9999", - "default_value": 0, - "value": "9999 if draft_shield_height_limitation == 'full' and draft_shield_enabled else 0.0", + "default_value": 10, + "value": "10", "enabled": "draft_shield_enabled and draft_shield_height_limitation == \"limited\"", "settable_per_mesh": false, "settable_per_extruder": false From 1bbf9879214f821bfb5f9aab40bb9089bf317473 Mon Sep 17 00:00:00 2001 From: fieldOfView Date: Thu, 28 Jul 2016 13:45:11 +0200 Subject: [PATCH 2/3] Fix SettingComboBox and SettingExtruder in some contexts Use propertyProvider instead of provider; fixes comboboxes in PostProcessing plugin. --- resources/qml/Settings/SettingComboBox.qml | 6 +++--- resources/qml/Settings/SettingExtruder.qml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/resources/qml/Settings/SettingComboBox.qml b/resources/qml/Settings/SettingComboBox.qml index 5308e45f5a..283e309e6a 100644 --- a/resources/qml/Settings/SettingComboBox.qml +++ b/resources/qml/Settings/SettingComboBox.qml @@ -86,18 +86,18 @@ SettingItem } } - onActivated: { forceActiveFocus(); provider.setPropertyValue("value", definition.options[index].key) } + onActivated: { forceActiveFocus(); propertyProvider.setPropertyValue("value", definition.options[index].key) } onModelChanged: updateCurrentIndex(); Connections { - target: provider + target: propertyProvider onPropertiesChanged: control.updateCurrentIndex() } function updateCurrentIndex() { for(var i = 0; i < definition.options.length; ++i) { - if(definition.options[i].key == provider.properties.value) { + if(definition.options[i].key == propertyProvider.properties.value) { currentIndex = i; return; } diff --git a/resources/qml/Settings/SettingExtruder.qml b/resources/qml/Settings/SettingExtruder.qml index 72c5299b15..d88fc9c457 100644 --- a/resources/qml/Settings/SettingExtruder.qml +++ b/resources/qml/Settings/SettingExtruder.qml @@ -105,13 +105,13 @@ SettingItem onActivated: { forceActiveFocus(); - provider.setPropertyValue("value", extruders_model.getItem(index).index) + propertyProvider.setPropertyValue("value", extruders_model.getItem(index).index) } onModelChanged: updateCurrentIndex(); Connections { - target: provider + target: propertyProvider onPropertiesChanged: control.updateCurrentIndex(); } @@ -119,7 +119,7 @@ SettingItem { for(var i = 0; i < extruders_model.rowCount(); ++i) { - if(extruders_model.getItem(i).index == provider.properties.value) + if(extruders_model.getItem(i).index == propertyProvider.properties.value) { currentIndex = i; return; From ce462ace17a2730c108215f414ff5b1b37b50c19 Mon Sep 17 00:00:00 2001 From: Jack Ha Date: Thu, 28 Jul 2016 13:48:43 +0200 Subject: [PATCH 3/3] Layout. CURA-1707 --- cura/ConvexHullNode.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/cura/ConvexHullNode.py b/cura/ConvexHullNode.py index 232b30e317..8e5acf9518 100644 --- a/cura/ConvexHullNode.py +++ b/cura/ConvexHullNode.py @@ -77,7 +77,7 @@ class ConvexHullNode(SceneNode): convex_hull_head = self._node.callDecoration("getConvexHullHead") if convex_hull_head: convex_hull_head_builder = MeshBuilder() - convex_hull_head_builder.addConvexPolygon(convex_hull_head.getPoints(), self._mesh_height-self._thickness) + convex_hull_head_builder.addConvexPolygon(convex_hull_head.getPoints(), self._mesh_height - self._thickness) self._convex_hull_head_mesh = convex_hull_head_builder.build() if not node: