From 362c5835ee5acc929b9b0a8180501314455cc6ff Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Wed, 1 Feb 2017 14:42:06 +0100 Subject: [PATCH] Don't use limit_to_extruder if it evaluates to -1 The default value for the limit_to_extruder property is -1. So no need to check if the property exists. Just check if it is positive. Contributes to issue CURA-3291. --- cura/Settings/MachineManager.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/cura/Settings/MachineManager.py b/cura/Settings/MachineManager.py index 16ff1f59c0..bd431340e3 100644 --- a/cura/Settings/MachineManager.py +++ b/cura/Settings/MachineManager.py @@ -301,10 +301,9 @@ class MachineManager(QObject): if not self._stacks_have_errors: # fast update, we only have to look at the current changed property if self._active_container_stack.getProperty(key, "settable_per_extruder"): - if self._active_container_stack.hasProperty(key, "limit_to_extruder"): #We have to look this value up from a different extruder. - extruder_index = self._active_container_stack.getProperty(key, "limit_to_extruder") - extruder_manager = ExtruderManager.getInstance() - stack = extruder_manager.getExtruderStack(extruder_index) + extruder_index = int(self._active_container_stack.getProperty(key, "limit_to_extruder")) + if extruder_index >= 0: #We have to look up the value from a different extruder. + stack = ExtruderManager.getInstance().getExtruderStack(str(extruder_index)) else: stack = self._active_container_stack else: