From 3f83799229f2fab5167c9331ac44d12c4eb7f9f0 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Mon, 8 May 2023 11:04:27 +0200 Subject: [PATCH] Only show build volume height message if it was changed Fixes #15373 && CURA-10580 --- cura/BuildVolume.py | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/cura/BuildVolume.py b/cura/BuildVolume.py index 1536d541c7..0d6ecf5810 100755 --- a/cura/BuildVolume.py +++ b/cura/BuildVolume.py @@ -648,11 +648,13 @@ class BuildVolume(SceneNode): self._width = self._global_container_stack.getProperty("machine_width", "value") machine_height = self._global_container_stack.getProperty("machine_height", "value") if self._global_container_stack.getProperty("print_sequence", "value") == "one_at_a_time" and len(self._scene_objects) > 1: - self._height = min(self._global_container_stack.getProperty("gantry_height", "value") * self._scale_vector.z, machine_height) - if self._height < (machine_height * self._scale_vector.z): + new_height = min(self._global_container_stack.getProperty("gantry_height", "value") * self._scale_vector.z, machine_height) + + if self._height > new_height: self._build_volume_message.show() - else: + elif self._height < new_height: self._build_volume_message.hide() + self._height = new_height else: self._height = self._global_container_stack.getProperty("machine_height", "value") self._build_volume_message.hide() @@ -690,11 +692,15 @@ class BuildVolume(SceneNode): if setting_key == "print_sequence": machine_height = self._global_container_stack.getProperty("machine_height", "value") if self._application.getGlobalContainerStack().getProperty("print_sequence", "value") == "one_at_a_time" and len(self._scene_objects) > 1: - self._height = min(self._global_container_stack.getProperty("gantry_height", "value") * self._scale_vector.z, machine_height) - if self._height < (machine_height * self._scale_vector.z): + new_height = min( + self._global_container_stack.getProperty("gantry_height", "value") * self._scale_vector.z, + machine_height) + + if self._height > new_height: self._build_volume_message.show() - else: + elif self._height < new_height: self._build_volume_message.hide() + self._height = new_height else: self._height = self._global_container_stack.getProperty("machine_height", "value") * self._scale_vector.z self._build_volume_message.hide()