From 423b4ad8693fbe848a871f8999f65813b0c7d11b Mon Sep 17 00:00:00 2001
From: Jaime van Kessel <nallath@gmail.com>
Date: Wed, 4 Sep 2019 17:16:07 +0200
Subject: [PATCH] Fix binding loop

CURA-6598
---
 resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml    | 2 ++
 .../qml/PrintSetupSelector/Custom/QualitiesWithIntentMenu.qml   | 1 +
 2 files changed, 3 insertions(+)

diff --git a/resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml b/resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml
index d38dfc14f8..682aefa821 100644
--- a/resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml
+++ b/resources/qml/PrintSetupSelector/Custom/CustomPrintSetup.qml
@@ -61,6 +61,8 @@ Item
             height: textLabel.contentHeight + 2 * UM.Theme.getSize("narrow_margin").height
             hoverEnabled: true
 
+            baselineOffset: null // If we don't do this, there is a binding loop. WHich is a bit weird, since we override the contentItem anyway...
+
             contentItem: Label
             {
                 id: textLabel
diff --git a/resources/qml/PrintSetupSelector/Custom/QualitiesWithIntentMenu.qml b/resources/qml/PrintSetupSelector/Custom/QualitiesWithIntentMenu.qml
index 888a6ab309..96c8431112 100644
--- a/resources/qml/PrintSetupSelector/Custom/QualitiesWithIntentMenu.qml
+++ b/resources/qml/PrintSetupSelector/Custom/QualitiesWithIntentMenu.qml
@@ -20,6 +20,7 @@ Popup
     topPadding: UM.Theme.getSize("narrow_margin").height
     rightPadding: UM.Theme.getSize("default_lining").width
     leftPadding: UM.Theme.getSize("default_lining").width
+
     padding: 0
     closePolicy: Popup.CloseOnEscape | Popup.CloseOnPressOutsideParent
     background: Cura.RoundedRectangle