Apply suggestions from code review

Co-authored-by: Casper Lamboo <c.lamboo@ultimaker.com>
This commit is contained in:
Saumya Jain 2024-04-26 10:26:52 +02:00 committed by GitHub
parent 0ce09d917c
commit 467801bf9e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -18,7 +18,6 @@ class Profile(Linter):
if self._file.exists() and self._settings["checks"].get("diagnostic-long-profile-names", False): if self._file.exists() and self._settings["checks"].get("diagnostic-long-profile-names", False):
for check in self.checklengthofProfileName(): for check in self.checklengthofProfileName():
yield check yield check
yield
def checklengthofProfileName(self) -> Iterator[Diagnostic]: def checklengthofProfileName(self) -> Iterator[Diagnostic]:
@ -35,7 +34,7 @@ class Profile(Linter):
) )
yield yield
def _getprofileName(self) -> dict: def _getprofileName(self) -> Tuple[str, bool]:
config = ConfigParser() config = ConfigParser()
config.read([self._file]) config.read([self._file])
name_of_profile = config.get("general", "name") name_of_profile = config.get("general", "name")