From 46e6baf6aef01d63e3e9fb8f7046798285f4e46b Mon Sep 17 00:00:00 2001 From: Diego Prado Gesto Date: Tue, 23 Jul 2019 16:17:54 +0200 Subject: [PATCH] Make suggested changes Add anchors instead of using width Contributes to CURA-6518. --- .../resources/qml/ToolboxDownloadsPage.qml | 1 - .../resources/qml/ToolboxInstalledPage.qml | 28 ++++++++++++++++--- 2 files changed, 24 insertions(+), 5 deletions(-) diff --git a/plugins/Toolbox/resources/qml/ToolboxDownloadsPage.qml b/plugins/Toolbox/resources/qml/ToolboxDownloadsPage.qml index c9bb74afea..5ea24d17ba 100644 --- a/plugins/Toolbox/resources/qml/ToolboxDownloadsPage.qml +++ b/plugins/Toolbox/resources/qml/ToolboxDownloadsPage.qml @@ -7,7 +7,6 @@ import UM 1.1 as UM ScrollView { - id: base clip: true width: parent.width height: parent.height diff --git a/plugins/Toolbox/resources/qml/ToolboxInstalledPage.qml b/plugins/Toolbox/resources/qml/ToolboxInstalledPage.qml index 1079331185..f4a9e634c4 100644 --- a/plugins/Toolbox/resources/qml/ToolboxInstalledPage.qml +++ b/plugins/Toolbox/resources/qml/ToolboxInstalledPage.qml @@ -23,7 +23,12 @@ ScrollView Label { - width: parent.width - 2 * parent.padding + anchors + { + left: parent.left + right: parent.right + margins: parent.padding + } text: catalog.i18nc("@title:tab", "Plugins") color: UM.Theme.getColor("text_medium") font: UM.Theme.getFont("large") @@ -32,9 +37,14 @@ ScrollView Rectangle { + anchors + { + left: parent.left + right: parent.right + margins: parent.padding + } id: installedPlugins color: "transparent" - width: parent.width - 2 * parent.padding height: childrenRect.height + UM.Theme.getSize("default_margin").width border.color: UM.Theme.getColor("lining") border.width: UM.Theme.getSize("default_lining").width @@ -58,7 +68,12 @@ ScrollView Label { - width: parent.width - 2 * parent.padding + anchors + { + left: parent.left + right: parent.right + margins: parent.padding + } text: catalog.i18nc("@title:tab", "Materials") color: UM.Theme.getColor("text_medium") font: UM.Theme.getFont("medium") @@ -67,9 +82,14 @@ ScrollView Rectangle { + anchors + { + left: parent.left + right: parent.right + margins: parent.padding + } id: installedMaterials color: "transparent" - width: parent.width - 2 * parent.padding height: childrenRect.height + UM.Theme.getSize("default_margin").width border.color: UM.Theme.getColor("lining") border.width: UM.Theme.getSize("default_lining").width