From 4ad36e94c542b150bf05606e06e819a534e156f4 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Fri, 30 Sep 2016 16:45:40 +0200 Subject: [PATCH 01/11] JSON: refine line width warning formulas (CURA-905) --- resources/definitions/fdmprinter.def.json | 39 ++++++++++++----------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 3aa45f7af7..9e1ea4a8b0 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -551,7 +551,7 @@ "type": "float", "default_value": 0.3, "minimum_value": "0.001", - "minimum_value_warning": "0.04", + "minimum_value_warning": "0.1", "maximum_value_warning": "0.8 * min(extruderValues('machine_nozzle_size'))", "settable_per_mesh": false, "settable_per_extruder": false @@ -562,7 +562,7 @@ "description": "Width of a single line. Generally, the width of each line should correspond to the width of the nozzle. However, slightly reducing this value could produce better prints.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.2", + "minimum_value_warning": "0.5 * machine_nozzle_size", "maximum_value_warning": "2 * machine_nozzle_size", "default_value": 0.4, "type": "float", @@ -576,8 +576,8 @@ "description": "Width of a single wall line.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.2", - "maximum_value_warning": "5", + "minimum_value_warning": "0.75 * machine_nozzle_size", + "maximum_value_warning": "2 * machine_nozzle_size", "value":"line_width", "default_value": 0.4, "type": "float", @@ -590,8 +590,8 @@ "description": "Width of the outermost wall line. By lowering this value, higher levels of detail can be printed.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.2", - "maximum_value_warning": "5", + "minimum_value_warning": "0.1 * machine_nozzle_size if wall_0_inset > 0 else 0.75 * machine_nozzle_size", + "maximum_value_warning": "2 * machine_nozzle_size", "default_value": 0.4, "value":"wall_line_width", "type": "float", @@ -603,8 +603,8 @@ "description": "Width of a single wall line for all wall lines except the outermost one.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.2", - "maximum_value_warning": "5", + "minimum_value_warning": "0.1 * machine_nozzle_size", + "maximum_value_warning": "2 * machine_nozzle_size", "default_value": 0.4, "value":"wall_line_width", "type": "float", @@ -618,8 +618,8 @@ "description": "Width of a single top/bottom line.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.2", - "maximum_value_warning": "5", + "minimum_value_warning": "0.1 * machine_nozzle_size", + "maximum_value_warning": "2 * machine_nozzle_size", "default_value": 0.4, "type": "float", "value": "line_width", @@ -631,8 +631,8 @@ "description": "Width of a single infill line.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.2", - "maximum_value_warning": "5", + "minimum_value_warning": "0.75 * machine_nozzle_size", + "maximum_value_warning": "3 * machine_nozzle_size", "default_value": 0.4, "type": "float", "value": "line_width", @@ -645,8 +645,8 @@ "description": "Width of a single skirt or brim line.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.2", - "maximum_value_warning": "5", + "minimum_value_warning": "0.75 * machine_nozzle_size", + "maximum_value_warning": "3 * machine_nozzle_size", "default_value": 0.4, "type": "float", "value": "line_width", @@ -660,8 +660,8 @@ "description": "Width of a single support structure line.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.2", - "maximum_value_warning": "5", + "minimum_value_warning": "0.75 * machine_nozzle_size", + "maximum_value_warning": "3 * machine_nozzle_size", "default_value": 0.4, "type": "float", "enabled": "support_enable", @@ -677,7 +677,8 @@ "unit": "mm", "default_value": 0.4, "minimum_value": "0.0001", - "maximum_value_warning": "machine_nozzle_size * 2", + "minimum_value_warning": "0.2 * machine_nozzle_size", + "maximum_value_warning": "2 * machine_nozzle_size", "type": "float", "enabled": "extruderValue(support_interface_extruder_nr, 'support_interface_enable')", "limit_to_extruder": "support_interface_extruder_nr", @@ -695,8 +696,8 @@ "default_value": 0.4, "value": "line_width", "minimum_value": "0.0001", - "minimum_value_warning": "0.2", - "maximum_value_warning": "5", + "minimum_value_warning": "0.75 * machine_nozzle_size", + "maximum_value_warning": "2 * machine_nozzle_size", "settable_per_mesh": false, "settable_per_extruder": true } From 163b8a425635a4ab1631b9f11fd8ddfef7f409a9 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Fri, 30 Sep 2016 16:50:39 +0200 Subject: [PATCH 02/11] JSON: refine shell settings warning formulas (CURA-905) --- resources/definitions/fdmprinter.def.json | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 9e1ea4a8b0..464ff02ed1 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -721,7 +721,7 @@ "default_value": 0.8, "minimum_value": "0", "minimum_value_warning": "line_width", - "maximum_value_warning": "5 * line_width", + "maximum_value_warning": "10 * line_width", "type": "float", "settable_per_mesh": true, "children": @@ -732,6 +732,8 @@ "description": "The number of walls. When calculated by the wall thickness, this value is rounded to a whole number.", "default_value": 2, "minimum_value": "0", + "minimum_value_warning": "0", + "maximum_value_warning": "10", "type": "int", "value": "1 if magic_spiralize else max(1, round((wall_thickness - wall_line_width_0) / wall_line_width_x) + 1) if wall_thickness != 0 else 0", "settable_per_mesh": true @@ -758,6 +760,7 @@ "unit": "mm", "default_value": 0.8, "minimum_value": "0", + "minimum_value_warning": "3 * layer_height", "maximum_value": "machine_height", "type": "float", "value": "top_bottom_thickness", @@ -772,6 +775,7 @@ "minimum_value": "0", "maximum_value_warning": "100", "type": "int", + "minimum_value_warning": "0", "value": "0 if infill_sparse_density == 100 else math.ceil(round(top_thickness / layer_height, 4))", "settable_per_mesh": true } @@ -784,6 +788,7 @@ "unit": "mm", "default_value": 0.6, "minimum_value": "0", + "minimum_value_warning": "3 * layer_height", "type": "float", "value": "top_bottom_thickness", "maximum_value": "machine_height", @@ -795,6 +800,7 @@ "label": "Bottom Layers", "description": "The number of bottom layers. When calculated by the bottom thickness, this value is rounded to a whole number.", "minimum_value": "0", + "minimum_value_warning": "3", "default_value": 6, "type": "int", "value": "999999 if infill_sparse_density == 100 else math.ceil(round(bottom_thickness / layer_height, 4))", @@ -879,8 +885,8 @@ "description": "Amount of offset applied to all polygons in each layer. Positive values can compensate for too big holes; negative values can compensate for too small holes.", "unit": "mm", "type": "float", - "minimum_value_warning": "-10", - "maximum_value_warning": "10", + "minimum_value_warning": "-1", + "maximum_value_warning": "1", "default_value": 0, "settable_per_mesh": true }, From bab01b9ca242a493eaed3c502c3dbae6c1b9c3c0 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Fri, 30 Sep 2016 16:55:28 +0200 Subject: [PATCH 03/11] JSON: refine infill settings warning formulas (CURA-905) --- resources/definitions/fdmprinter.def.json | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 464ff02ed1..ab127e168b 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -942,6 +942,7 @@ "type": "float", "default_value": 2, "minimum_value": "0", + "minimum_value_warning": "infill_line_width", "value": "0 if infill_sparse_density == 0 else (infill_line_width * 100) / infill_sparse_density * (2 if infill_pattern == 'grid' else (3 if infill_pattern == 'triangles' or infill_pattern == 'cubic' else (4 if infill_pattern == 'tetrahedral' else 1)))", "settable_per_mesh": true } @@ -1042,8 +1043,8 @@ "unit": "mm", "type": "float", "default_value": 0.1, - "minimum_value": "0.0001", - "maximum_value_warning": "0.32", + "minimum_value": "layer_height", + "maximum_value_warning": "0.75 * machine_nozzle_size", "maximum_value": "layer_height * 8", "value": "layer_height", "enabled": "infill_sparse_density > 0", @@ -1069,6 +1070,7 @@ "type": "float", "default_value": 5.0, "minimum_value": "0.0001", + "minimum_value_warning": "3 * layer_height", "maximum_value_warning": "100", "enabled": "infill_sparse_density > 0 and gradual_infill_steps > 0", "settable_per_mesh": true From e12e8e3d2e735b87a9562968d09401ccbc2f8bdb Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Fri, 30 Sep 2016 17:20:00 +0200 Subject: [PATCH 04/11] JSON: refine material settings warning formulas (CURA-905) --- resources/definitions/fdmprinter.def.json | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index ab127e168b..863ce12c5f 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -1112,6 +1112,7 @@ "type": "float", "default_value": 210, "minimum_value": "-273.15", + "minimum_value_warning": "0", "maximum_value_warning": "260", "enabled": "not (material_flow_dependent_temperature)", "settable_per_mesh": false, @@ -1150,6 +1151,7 @@ "resolve": "sum(extruderValues('material_bed_temperature')) / len(extruderValues('material_bed_temperature'))", "default_value": 60, "minimum_value": "-273.15", + "minimum_value_warning": "0", "maximum_value_warning": "260", "enabled": "machine_heated_bed", "settable_per_mesh": false, @@ -1206,6 +1208,7 @@ "type": "float", "default_value": 25, "minimum_value": "0", + "minimum_value_warning": "1", "maximum_value": "machine_max_feedrate_e", "maximum_value_warning": "25", "enabled": "retraction_enable", @@ -1220,6 +1223,7 @@ "default_value": 25, "minimum_value": "0", "maximum_value": "machine_max_feedrate_e", + "minimum_value_warning": "1", "maximum_value_warning": "25", "enabled": "retraction_enable", "value": "retraction_speed", @@ -1234,6 +1238,7 @@ "default_value": 25, "minimum_value": "0", "maximum_value": "machine_max_feedrate_e", + "minimum_value_warning": "1", "maximum_value_warning": "25", "enabled": "retraction_enable", "value": "retraction_speed", @@ -1315,7 +1320,7 @@ "unit": "mm", "type": "float", "default_value": 1, - "minimum_value_warning": "-0.0001", + "minimum_value_warning": "0.75 * machine_nozzle_size", "maximum_value_warning": "10", "enabled": "retraction_enable and retraction_hop_enabled", "settable_per_mesh": false, @@ -1329,6 +1334,7 @@ "unit": "°C", "default_value": 150, "minimum_value": "-273.15", + "minimum_value_warning": "0", "maximum_value_warning": "260", "settable_per_mesh": false, "settable_per_extruder": true @@ -1356,7 +1362,7 @@ "enabled": "retraction_enable", "default_value": 20, "minimum_value": "0.1", - "maximum_value_warning": "300", + "maximum_value_warning": "25", "settable_per_mesh": false, "settable_per_extruder": true, "children": @@ -1371,7 +1377,7 @@ "default_value": 20, "value": "switch_extruder_retraction_speeds", "minimum_value": "0.1", - "maximum_value_warning": "300", + "maximum_value_warning": "25", "settable_per_mesh": false, "settable_per_extruder": true }, @@ -1385,7 +1391,7 @@ "default_value": 20, "value": "switch_extruder_retraction_speeds", "minimum_value": "0.1", - "maximum_value_warning": "300", + "maximum_value_warning": "25", "settable_per_mesh": false, "settable_per_extruder": true } From 2e24cddbc7ab4c2dc2072b7288a942c2e12c8d4f Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Fri, 30 Sep 2016 17:46:09 +0200 Subject: [PATCH 05/11] JSON: refine support settings warning formulas (CURA-905) --- resources/definitions/fdmprinter.def.json | 38 ++++++++++++++--------- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 863ce12c5f..83eeac89d9 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2169,6 +2169,7 @@ "default_value": 0.625, "value": "machine_nozzle_tip_outer_diameter / 2 * 1.25", "minimum_value": "0", + "minimum_value_warning": "machine_nozzle_tip_outer_diameter * 0.5", "maximum_value_warning": "machine_nozzle_tip_outer_diameter * 5", "enabled": "retraction_combing != 'off' and travel_avoid_other_parts", "settable_per_mesh": false, @@ -2271,7 +2272,7 @@ "type": "int", "default_value": 2, "minimum_value": "1", - "maximum_value_warning": "100", + "maximum_value_warning": "10 / layer_height", "value": "max(1, int(math.floor((cool_fan_full_at_height - layer_height_0) / layer_height) + 2))", "settable_per_mesh": false, "settable_per_extruder": true @@ -2353,6 +2354,7 @@ "type": "float", "minimum_value": "0", "maximum_value": "90", + "maximum_value_warning": "80", "default_value": 50, "limit_to_extruder": "support_interface_extruder_nr if support_interface_enable else support_infill_extruder_nr", "enabled": "support_enable", @@ -2409,6 +2411,7 @@ "unit": "mm", "type": "float", "minimum_value": "0", + "minimum_value_warning": "support_line_width", "default_value": 2.66, "enabled": "support_enable", "value": "(support_line_width * 100) / support_infill_rate * (2 if support_pattern == 'grid' else (3 if support_pattern == 'triangles' else 1))", @@ -2425,7 +2428,7 @@ "unit": "mm", "type": "float", "minimum_value": "0", - "maximum_value_warning": "10", + "maximum_value_warning": "machine_nozzle_size", "default_value": 0.1, "limit_to_extruder": "support_interface_extruder_nr if support_interface_enable else support_infill_extruder_nr", "enabled": "support_enable", @@ -2438,7 +2441,7 @@ "description": "Distance from the top of the support to the print.", "unit": "mm", "minimum_value": "0", - "maximum_value_warning": "10", + "maximum_value_warning": "machine_nozzle_size", "default_value": 0.1, "type": "float", "enabled": "support_enable", @@ -2452,7 +2455,7 @@ "description": "Distance from the print to the bottom of the support.", "unit": "mm", "minimum_value": "0", - "maximum_value_warning": "10", + "maximum_value_warning": "machine_nozzle_size", "default_value": 0.1, "value": "extruderValue(support_extruder_nr, 'support_z_distance') if support_type == 'everywhere' else 0", "limit_to_extruder": "support_interface_extruder_nr if support_interface_enable else support_infill_extruder_nr", @@ -2469,7 +2472,7 @@ "unit": "mm", "type": "float", "minimum_value": "0", - "maximum_value_warning": "10", + "maximum_value_warning": "4 * machine_nozzle_size", "default_value": 0.7, "limit_to_extruder": "support_infill_extruder_nr", "enabled": "support_enable", @@ -2494,7 +2497,7 @@ "unit": "mm", "type": "float", "minimum_value": "0", - "maximum_value_warning": "10", + "maximum_value_warning": "extruderValue(support_infill_extruder_nr, 'support_xy_distance')", "default_value": 0.2, "value": "machine_nozzle_size / 2", "limit_to_extruder": "support_infill_extruder_nr", @@ -2535,8 +2538,8 @@ "type": "float", "default_value": 0.2, "limit_to_extruder": "support_infill_extruder_nr", - "minimum_value_warning": "-0.5", - "maximum_value_warning": "5.0", + "minimum_value_warning": "-1 * machine_nozzle_size", + "maximum_value_warning": "10 * machine_nozzle_size", "enabled": "support_enable", "settable_per_mesh": true }, @@ -2558,8 +2561,9 @@ "type": "float", "default_value": 1, "minimum_value": "0", - "limit_to_extruder": "support_interface_extruder_nr", + "minimum_value_warning": "3 * layer_height", "maximum_value_warning": "10", + "limit_to_extruder": "support_interface_extruder_nr", "enabled": "extruderValue(support_interface_extruder_nr, 'support_interface_enable') and support_enable", "settable_per_mesh": true, "children": @@ -2571,10 +2575,11 @@ "unit": "mm", "type": "float", "default_value": 1, - "value": "extruderValue(support_interface_extruder_nr, 'support_interface_height')", "minimum_value": "0", - "limit_to_extruder": "support_interface_extruder_nr", + "minimum_value_warning": "3 * layer_height", "maximum_value_warning": "10", + "value": "extruderValue(support_interface_extruder_nr, 'support_interface_height')", + "limit_to_extruder": "support_interface_extruder_nr", "enabled": "extruderValue(support_interface_extruder_nr, 'support_interface_enable') and support_enable", "settable_per_mesh": true }, @@ -2587,9 +2592,9 @@ "default_value": 1, "value": "extruderValue(support_interface_extruder_nr, 'support_interface_height')", "minimum_value": "0", - "minimum_value_warning": "extruderValue(support_interface_extruder_nr, 'support_bottom_stair_step_height')", - "limit_to_extruder": "support_interface_extruder_nr", + "minimum_value_warning": "min(3 * layer_height, extruderValue(support_interface_extruder_nr, 'support_bottom_stair_step_height'))", "maximum_value_warning": "10", + "limit_to_extruder": "support_interface_extruder_nr", "enabled": "extruderValue(support_interface_extruder_nr, 'support_interface_enable') and support_enable", "settable_per_mesh": true } @@ -2631,6 +2636,7 @@ "type": "float", "default_value": 0.4, "minimum_value": "0", + "minimum_value_warning": "support_interface_line_width", "value": "0 if support_interface_density == 0 else (support_interface_line_width * 100) / support_interface_density * (2 if support_interface_pattern == 'grid' else (3 if support_interface_pattern == 'triangles' else 1))", "limit_to_extruder": "support_interface_extruder_nr", "enabled": "extruderValue(support_interface_extruder_nr, 'support_interface_enable') and support_enable", @@ -2677,7 +2683,8 @@ "default_value": 3.0, "limit_to_extruder": "support_infill_extruder_nr", "minimum_value": "0", - "maximum_value_warning": "10", + "minimum_value_warning": "2 * machine_nozzle_size", + "maximum_value_warning": "20", "enabled": "support_enable and extruderValue(support_infill_extruder_nr, 'support_use_towers')", "settable_per_mesh": true }, @@ -2690,7 +2697,8 @@ "default_value": 3.0, "limit_to_extruder": "support_infill_extruder_nr", "minimum_value": "0", - "maximum_value_warning": "10", + "minimum_value_warning": "2 * machine_nozzle_size", + "maximum_value_warning": "20", "maximum_value": "extruderValue(support_infill_extruder_nr, 'support_tower_diameter')", "enabled": "support_enable and extruderValue(support_infill_extruder_nr, 'support_use_towers')", "settable_per_mesh": true From 61d9ee9241a699b200db2f76a45cfc64585fef6f Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Fri, 30 Sep 2016 17:51:18 +0200 Subject: [PATCH 06/11] JSON: refine skirt/brim settings warning formulas (CURA-905) --- resources/definitions/fdmprinter.def.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 83eeac89d9..d1171970c5 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2788,8 +2788,8 @@ "unit": "mm", "type": "float", "default_value": 3, - "minimum_value_warning": "0", - "maximum_value_warning": "100", + "minimum_value_warning": "max(extruderValues('machine_nozzle_size')", + "maximum_value_warning": "10", "enabled": "resolveOrValue('adhesion_type') == 'skirt'", "settable_per_mesh": false, "settable_per_extruder": true, @@ -2817,7 +2817,7 @@ "unit": "mm", "default_value": 8.0, "minimum_value": "0.0", - "maximum_value_warning": "100.0", + "maximum_value_warning": "50.0", "enabled": "resolveOrValue('adhesion_type') == 'brim'", "settable_per_mesh": false, "settable_per_extruder": true, @@ -2831,7 +2831,7 @@ "type": "int", "default_value": 20, "minimum_value": "0", - "maximum_value_warning": "300", + "maximum_value_warning": "50 / skirt_brim_line_width", "value": "math.ceil(brim_width / skirt_brim_line_width)", "enabled": "resolveOrValue('adhesion_type') == 'brim'", "settable_per_mesh": false, From dbb472436d3c348967d750119c85764dde520bb6 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Fri, 30 Sep 2016 18:03:52 +0200 Subject: [PATCH 07/11] JSON: refine raft settings warning formulas (CURA-905) --- resources/definitions/fdmprinter.def.json | 35 ++++++++++++++--------- 1 file changed, 22 insertions(+), 13 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index d1171970c5..875cee01d8 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -2858,7 +2858,7 @@ "unit": "mm", "type": "float", "default_value": 15, - "minimum_value_warning": "0", + "minimum_value_warning": "raft_interface_line_width", "maximum_value_warning": "10", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "limit_to_extruder": "adhesion_extruder_nr", @@ -2873,7 +2873,7 @@ "type": "float", "default_value": 0.3, "minimum_value": "0", - "maximum_value_warning": "1.0", + "maximum_value_warning": "min(extruderValues('machine_nozzle_size'))", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false, "settable_per_extruder": true, @@ -2914,8 +2914,9 @@ "type": "float", "default_value": 0.1, "value": "layer_height", - "minimum_value": "0", - "maximum_value_warning": "2.0", + "minimum_value": "0.001", + "minimum_value_warning": "0.04", + "maximum_value_warning": "0.75 * extruderValue(adhesion_extruder_nr, 'machine_nozzle_size')", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false, "settable_per_extruder": true, @@ -2930,7 +2931,8 @@ "default_value": 0.4, "value": "line_width", "minimum_value": "0.0001", - "maximum_value_warning": "machine_nozzle_size * 2", + "maximum_value_warning": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 0.1", + "maximum_value_warning": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 2", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false, "settable_per_extruder": true, @@ -2944,7 +2946,8 @@ "type": "float", "default_value": 0.4, "minimum_value": "0.0001", - "maximum_value_warning": "5.0", + "minimum_value_warning": "extruderValue(adhesion_extruder_nr, 'raft_surface_line_width')", + "maximum_value_warning": "extruderValue(adhesion_extruder_nr, 'raft_surface_line_width') * 3", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "value": "raft_surface_line_width", "settable_per_mesh": false, @@ -2959,8 +2962,9 @@ "type": "float", "default_value": 0.15, "value": "layer_height * 1.5", - "minimum_value": "0", - "maximum_value_warning": "5.0", + "minimum_value": "0.001", + "minimum_value_warning": "0.04", + "maximum_value_warning": "0.75 * extruderValue(adhesion_extruder_nr, 'machine_nozzle_size')", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false, "settable_per_extruder": true, @@ -2975,7 +2979,8 @@ "default_value": 0.7, "value": "line_width * 2", "minimum_value": "0.0001", - "maximum_value_warning": "machine_nozzle_size * 2", + "minimum_value_warning": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 0.5", + "maximum_value_warning": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 3", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false, "settable_per_extruder": true, @@ -2990,6 +2995,7 @@ "default_value": 0.9, "value": "raft_interface_line_width + 0.2", "minimum_value": "0", + "minimum_value_warning": "extruderValue(adhesion_extruder_nr, 'raft_interface_line_width')", "maximum_value_warning": "15.0", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false, @@ -3004,8 +3010,9 @@ "type": "float", "default_value": 0.3, "value": "layer_height_0 * 1.2", - "minimum_value": "0", - "maximum_value_warning": "5.0", + "minimum_value": "0.001", + "minimum_value_warning": "0.04", + "maximum_value_warning": "0.75 * extruderValue(adhesion_extruder_nr, 'machine_nozzle_size')", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false, "settable_per_extruder": true, @@ -3019,8 +3026,9 @@ "type": "float", "default_value": 0.8, "minimum_value": "0.0001", - "value": "machine_nozzle_size * 2", - "maximum_value_warning": "machine_nozzle_size * 3", + "value": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 2", + "minimum_value_warning": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 0.5", + "maximum_value_warning": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 3", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false, "settable_per_extruder": true, @@ -3035,6 +3043,7 @@ "default_value": 1.6, "value": "raft_base_line_width * 2", "minimum_value": "0.0001", + "minimum_value_warning": "extruderValue(adhesion_extruder_nr, 'raft_base_line_width')", "maximum_value_warning": "100", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false, From d4d8ab6fadaec36eed44cda334a3ebe7439c644b Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Fri, 30 Sep 2016 18:08:18 +0200 Subject: [PATCH 08/11] JSON: refine dual settings warning formulas (CURA-905) --- resources/definitions/fdmprinter.def.json | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 875cee01d8..9ff9b2fe0e 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -3382,6 +3382,7 @@ "value": "15 if resolveOrValue('prime_tower_enable') else 0", "minimum_value": "0", "maximum_value": "min(0.5 * machine_width, 0.5 * machine_depth)", + "minimum_value_warning": "max(extruderValues('prime_tower_line_width')) * 2", "maximum_value_warning": "20", "settable_per_mesh": false, "settable_per_extruder": false @@ -3482,7 +3483,7 @@ "enabled": "ooze_shield_enabled", "default_value": 2, "minimum_value": "0", - "maximum_value_warning": "30", + "maximum_value_warning": "20", "settable_per_mesh": false, "settable_per_extruder": false } @@ -3626,7 +3627,7 @@ "unit": "mm", "type": "float", "minimum_value": "0", - "maximum_value_warning": "100", + "maximum_value_warning": "10", "default_value": 10, "enabled": "draft_shield_enabled", "settable_per_mesh": false, From 2513c64d7da07562274afc3ab556b837e45ca6cf Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Mon, 3 Oct 2016 17:29:25 +0200 Subject: [PATCH 09/11] JSON fix: more feasible warnings (CURA-905) --- resources/definitions/fdmprinter.def.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 9ff9b2fe0e..1c5d6d3e2c 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -603,7 +603,7 @@ "description": "Width of a single wall line for all wall lines except the outermost one.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.1 * machine_nozzle_size", + "minimum_value_warning": "0.5 * machine_nozzle_size", "maximum_value_warning": "2 * machine_nozzle_size", "default_value": 0.4, "value":"wall_line_width", @@ -677,7 +677,7 @@ "unit": "mm", "default_value": 0.4, "minimum_value": "0.0001", - "minimum_value_warning": "0.2 * machine_nozzle_size", + "minimum_value_warning": "0.4 * machine_nozzle_size", "maximum_value_warning": "2 * machine_nozzle_size", "type": "float", "enabled": "extruderValue(support_interface_extruder_nr, 'support_interface_enable')", @@ -2788,7 +2788,7 @@ "unit": "mm", "type": "float", "default_value": 3, - "minimum_value_warning": "max(extruderValues('machine_nozzle_size')", + "minimum_value_warning": "max(extruderValues('machine_nozzle_size'))", "maximum_value_warning": "10", "enabled": "resolveOrValue('adhesion_type') == 'skirt'", "settable_per_mesh": false, From 9b342a9a3e4d64706cd8b3686cd5c4390f94d621 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Mon, 3 Oct 2016 17:35:28 +0200 Subject: [PATCH 10/11] JSON fix: removed circular dependency (CURA-905) --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 1c5d6d3e2c..4d710ddcc9 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -590,7 +590,7 @@ "description": "Width of the outermost wall line. By lowering this value, higher levels of detail can be printed.", "unit": "mm", "minimum_value": "0.0001", - "minimum_value_warning": "0.1 * machine_nozzle_size if wall_0_inset > 0 else 0.75 * machine_nozzle_size", + "minimum_value_warning": "0.75 * machine_nozzle_size if outer_inset_first else 0.1 * machine_nozzle_size", "maximum_value_warning": "2 * machine_nozzle_size", "default_value": 0.4, "value":"wall_line_width", From 6240baaaca4dedbd2822218189fc97795a3d9874 Mon Sep 17 00:00:00 2001 From: Tim Kuipers Date: Mon, 3 Oct 2016 17:56:03 +0200 Subject: [PATCH 11/11] JSON fix: better warning formulas (CURA-905) --- resources/definitions/fdmprinter.def.json | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 4d710ddcc9..6eba80ad31 100644 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -732,7 +732,7 @@ "description": "The number of walls. When calculated by the wall thickness, this value is rounded to a whole number.", "default_value": 2, "minimum_value": "0", - "minimum_value_warning": "0", + "minimum_value_warning": "1", "maximum_value_warning": "10", "type": "int", "value": "1 if magic_spiralize else max(1, round((wall_thickness - wall_line_width_0) / wall_line_width_x) + 1) if wall_thickness != 0 else 0", @@ -775,7 +775,7 @@ "minimum_value": "0", "maximum_value_warning": "100", "type": "int", - "minimum_value_warning": "0", + "minimum_value_warning": "4", "value": "0 if infill_sparse_density == 100 else math.ceil(round(top_thickness / layer_height, 4))", "settable_per_mesh": true } @@ -800,7 +800,7 @@ "label": "Bottom Layers", "description": "The number of bottom layers. When calculated by the bottom thickness, this value is rounded to a whole number.", "minimum_value": "0", - "minimum_value_warning": "3", + "minimum_value_warning": "4", "default_value": 6, "type": "int", "value": "999999 if infill_sparse_density == 100 else math.ceil(round(bottom_thickness / layer_height, 4))", @@ -2472,7 +2472,7 @@ "unit": "mm", "type": "float", "minimum_value": "0", - "maximum_value_warning": "4 * machine_nozzle_size", + "maximum_value_warning": "1.5 * machine_nozzle_tip_outer_diameter", "default_value": 0.7, "limit_to_extruder": "support_infill_extruder_nr", "enabled": "support_enable", @@ -2931,7 +2931,7 @@ "default_value": 0.4, "value": "line_width", "minimum_value": "0.0001", - "maximum_value_warning": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 0.1", + "minimum_value_warning": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 0.1", "maximum_value_warning": "extruderValue(adhesion_extruder_nr, 'machine_nozzle_size') * 2", "enabled": "resolveOrValue('adhesion_type') == 'raft'", "settable_per_mesh": false,