From 50e2db47c8a729fb990c6c960df6463eb43b309a Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Wed, 25 Apr 2018 14:24:47 +0200 Subject: [PATCH] Fix can_upgrade flag for non-working plugins CURA-5287 --- plugins/PluginBrowser/PluginBrowser.py | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/PluginBrowser/PluginBrowser.py b/plugins/PluginBrowser/PluginBrowser.py index f85c2cb85f..10c05e6907 100644 --- a/plugins/PluginBrowser/PluginBrowser.py +++ b/plugins/PluginBrowser/PluginBrowser.py @@ -309,8 +309,12 @@ class PluginBrowser(QObject, Extension): try: plugin_object = self._plugin_registry.getPluginObject(plugin_id) except PluginNotFoundError: + # CURA-5287 + # At this point, we know that this plugin is installed because it passed the previous check, but we cannot + # get the PluginObject. This means there is a bug in the plugin or something. So, we always allow to upgrade + # this plugin and hopefully that fixes it. Logger.log("w", "Could not find plugin %s", plugin_id) - return False + return True # Scan plugin server data for plugin with the given id: for plugin in self._plugins_metadata: