From 536c95555ec42874ca1017e09f5e402dc41965b5 Mon Sep 17 00:00:00 2001 From: Thomas Rahm <67757218+ThomasRahm@users.noreply.github.com> Date: Wed, 29 Mar 2023 06:50:30 +0200 Subject: [PATCH] Suggested profile changes: Ensure minimum support area is 0 for tree support to avoid 'No trees generated' bug report. Removed extra z heightfor Tree support as this should no longer be required with the new implementation --- resources/definitions/Geeetech_Base_Dual_Extruder.def.json | 2 +- resources/definitions/Geeetech_Base_Multi_Extruder.def.json | 2 +- resources/definitions/Geeetech_Base_Single_Extruder.def.json | 2 +- resources/definitions/ankermake_m5.def.json | 2 +- resources/definitions/anycubic_i3_mega_s.def.json | 4 ++-- resources/definitions/artillery_base.def.json | 2 +- resources/definitions/biqu_base.def.json | 2 +- resources/definitions/blocks_base.def.json | 2 +- resources/definitions/creality_base.def.json | 4 ++-- resources/definitions/flyingbear_base.def.json | 2 +- resources/definitions/fusion3_f410.def.json | 2 +- resources/definitions/kingroon_base.def.json | 2 +- resources/definitions/koonovo_base.def.json | 2 +- resources/definitions/koonovo_kn3.def.json | 2 +- resources/definitions/koonovo_kn5.def.json | 2 +- resources/definitions/lnl3d_base.def.json | 2 +- resources/definitions/longer_base.def.json | 2 +- resources/definitions/mingda_base.def.json | 2 +- resources/definitions/mixware_hyper_k.def.json | 2 +- resources/definitions/modix_v3_base.def.json | 2 +- resources/definitions/modix_v4_base.def.json | 2 +- resources/definitions/rigid3d_base.def.json | 2 +- resources/definitions/tank_m_base.def.json | 2 +- resources/definitions/tronxy_x.def.json | 2 +- resources/definitions/two_trees_base.def.json | 2 +- resources/definitions/vivedino_base.def.json | 2 +- 26 files changed, 28 insertions(+), 28 deletions(-) diff --git a/resources/definitions/Geeetech_Base_Dual_Extruder.def.json b/resources/definitions/Geeetech_Base_Dual_Extruder.def.json index 7bc2bc529c..c8ab3ca623 100644 --- a/resources/definitions/Geeetech_Base_Dual_Extruder.def.json +++ b/resources/definitions/Geeetech_Base_Dual_Extruder.def.json @@ -81,7 +81,7 @@ "value": "material_print_temperature + 5" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": true }, "prime_tower_brim_enable": { "value": true }, "prime_tower_min_volume": diff --git a/resources/definitions/Geeetech_Base_Multi_Extruder.def.json b/resources/definitions/Geeetech_Base_Multi_Extruder.def.json index 4d4bc3363a..36783200dd 100644 --- a/resources/definitions/Geeetech_Base_Multi_Extruder.def.json +++ b/resources/definitions/Geeetech_Base_Multi_Extruder.def.json @@ -82,7 +82,7 @@ "value": "material_print_temperature + 5" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": true }, "prime_tower_brim_enable": { "value": true }, "prime_tower_min_volume": diff --git a/resources/definitions/Geeetech_Base_Single_Extruder.def.json b/resources/definitions/Geeetech_Base_Single_Extruder.def.json index b155a0ee6c..b901668859 100644 --- a/resources/definitions/Geeetech_Base_Single_Extruder.def.json +++ b/resources/definitions/Geeetech_Base_Single_Extruder.def.json @@ -76,7 +76,7 @@ "value": "material_print_temperature + 5" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": true }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'all'" }, "retraction_combing_max_distance": { "value": 30 }, diff --git a/resources/definitions/ankermake_m5.def.json b/resources/definitions/ankermake_m5.def.json index 6d8b0b15e9..47ea58528c 100644 --- a/resources/definitions/ankermake_m5.def.json +++ b/resources/definitions/ankermake_m5.def.json @@ -74,7 +74,7 @@ "value": "material_print_temperature + 5" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "retraction_amount": { "default_value": 1.5 }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'infill'" }, "retraction_hop": { "value": 0.2 }, diff --git a/resources/definitions/anycubic_i3_mega_s.def.json b/resources/definitions/anycubic_i3_mega_s.def.json index 60b5bf652c..7837b9ab10 100644 --- a/resources/definitions/anycubic_i3_mega_s.def.json +++ b/resources/definitions/anycubic_i3_mega_s.def.json @@ -68,7 +68,7 @@ }, "meshfix_maximum_deviation": { "value": 0.05 }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retraction_amount": { "value": 6 }, "retraction_combing": { "value": "'off'" }, @@ -113,7 +113,7 @@ "support_interface_skip_height": { "value": 0.2 }, "support_pattern": { "value": "'zigzag'" }, "support_structure": { "value": "'tree'" }, - "support_top_distance": { "value": "extruderValue(support_roof_extruder_nr if support_roof_enable else support_infill_extruder_nr, 'support_z_distance') + (layer_height if support_structure == 'tree' else 0)" }, + "support_top_distance": { "value": "extruderValue(support_roof_extruder_nr if support_roof_enable else support_infill_extruder_nr, 'support_z_distance')" }, "support_type": { "value": "'buildplate' if support_structure == 'tree' else 'everywhere'" }, "support_wall_count": { "value": 1 }, "support_xy_distance": { "value": "wall_line_width_0 * 2" }, diff --git a/resources/definitions/artillery_base.def.json b/resources/definitions/artillery_base.def.json index e8b779bf00..d12587e383 100644 --- a/resources/definitions/artillery_base.def.json +++ b/resources/definitions/artillery_base.def.json @@ -110,7 +110,7 @@ "meshfix_maximum_resolution": { "value": "0.25" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": true }, "retraction_amount": { "value": 2 }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'infill'" }, diff --git a/resources/definitions/biqu_base.def.json b/resources/definitions/biqu_base.def.json index 5b84c72b88..78edc62b74 100755 --- a/resources/definitions/biqu_base.def.json +++ b/resources/definitions/biqu_base.def.json @@ -63,7 +63,7 @@ "meshfix_maximum_resolution": { "value": "0.25" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'noskin'" }, "retraction_combing_max_distance": { "value": 30 }, diff --git a/resources/definitions/blocks_base.def.json b/resources/definitions/blocks_base.def.json index b8e215ab5f..d83e6b31f6 100644 --- a/resources/definitions/blocks_base.def.json +++ b/resources/definitions/blocks_base.def.json @@ -55,7 +55,7 @@ "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, "minimum_polygon_circumference": { "default_value": 0.2 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'noskin'" }, "retraction_combing_max_distance": { "value": 30 }, diff --git a/resources/definitions/creality_base.def.json b/resources/definitions/creality_base.def.json index 229c46d7ca..e0af584423 100644 --- a/resources/definitions/creality_base.def.json +++ b/resources/definitions/creality_base.def.json @@ -113,7 +113,7 @@ "meshfix_maximum_resolution": { "value": "0.25" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'noskin'" }, "retraction_combing_max_distance": { "value": 30 }, @@ -159,7 +159,7 @@ "support_interface_pattern": { "value": "'grid'" }, "support_interface_skip_height": { "value": 0.2 }, "support_pattern": { "value": "'zigzag'" }, - "support_top_distance": { "value": "extruderValue(support_roof_extruder_nr if support_roof_enable else support_infill_extruder_nr, 'support_z_distance') + (layer_height if support_structure == 'tree' else 0)" }, + "support_top_distance": { "value": "extruderValue(support_roof_extruder_nr if support_roof_enable else support_infill_extruder_nr, 'support_z_distance')" }, "support_wall_count": { "value": 1 }, "support_xy_distance": { "value": "wall_line_width_0 * 2" }, "support_xy_distance_overhang": { "value": "wall_line_width_0" }, diff --git a/resources/definitions/flyingbear_base.def.json b/resources/definitions/flyingbear_base.def.json index dcbeca1e9e..c256ae61f8 100644 --- a/resources/definitions/flyingbear_base.def.json +++ b/resources/definitions/flyingbear_base.def.json @@ -128,7 +128,7 @@ "meshfix_maximum_resolution": { "value": 0.25 }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 5 }, + "minimum_support_area": { "value": "5 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": true }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'noskin'" }, "retraction_combing_max_distance": { "value": 30 }, diff --git a/resources/definitions/fusion3_f410.def.json b/resources/definitions/fusion3_f410.def.json index 1c4fce0d44..6f50a15fd8 100644 --- a/resources/definitions/fusion3_f410.def.json +++ b/resources/definitions/fusion3_f410.def.json @@ -60,7 +60,7 @@ "meshfix_maximum_resolution": { "value": "0.25" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retract_at_layer_change": { "value": true }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'noskin'" }, diff --git a/resources/definitions/kingroon_base.def.json b/resources/definitions/kingroon_base.def.json index 5f23b602b9..2530ae87b4 100644 --- a/resources/definitions/kingroon_base.def.json +++ b/resources/definitions/kingroon_base.def.json @@ -177,7 +177,7 @@ "meshfix_maximum_resolution": { "value": "0.05" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": true }, "retraction_amount": { "value": 2 }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'infill'" }, diff --git a/resources/definitions/koonovo_base.def.json b/resources/definitions/koonovo_base.def.json index 906293bd59..b22a4267d1 100644 --- a/resources/definitions/koonovo_base.def.json +++ b/resources/definitions/koonovo_base.def.json @@ -48,7 +48,7 @@ "material_initial_print_temperature": { "value": "material_print_temperature" }, "material_standby_temperature": { "value": "material_print_temperature" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "retraction_amount": { "value": 2.5 }, "retraction_speed": { "value": 40 }, "skirt_gap": { "value": 6.0 }, diff --git a/resources/definitions/koonovo_kn3.def.json b/resources/definitions/koonovo_kn3.def.json index 13981334b8..ae978b12e0 100644 --- a/resources/definitions/koonovo_kn3.def.json +++ b/resources/definitions/koonovo_kn3.def.json @@ -66,7 +66,7 @@ "material_initial_print_temperature": { "value": "material_print_temperature" }, "material_standby_temperature": { "value": "material_print_temperature" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "retraction_amount": { "value": 2.5 }, "retraction_speed": { "value": 40 }, "skirt_gap": { "value": 6.0 }, diff --git a/resources/definitions/koonovo_kn5.def.json b/resources/definitions/koonovo_kn5.def.json index 29bd0c75de..96ae03a6d9 100644 --- a/resources/definitions/koonovo_kn5.def.json +++ b/resources/definitions/koonovo_kn5.def.json @@ -66,7 +66,7 @@ "material_initial_print_temperature": { "value": "material_print_temperature" }, "material_standby_temperature": { "value": "material_print_temperature" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "retraction_amount": { "value": 2.5 }, "retraction_speed": { "value": 40 }, "skirt_gap": { "value": 6.0 }, diff --git a/resources/definitions/lnl3d_base.def.json b/resources/definitions/lnl3d_base.def.json index c181e80a8e..5d865808fd 100644 --- a/resources/definitions/lnl3d_base.def.json +++ b/resources/definitions/lnl3d_base.def.json @@ -65,7 +65,7 @@ "meshfix_maximum_resolution": { "value": "0.25" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "prime_tower_brim_enable": { "default_value": true }, "prime_tower_wipe_enabled": { "default_value": false }, diff --git a/resources/definitions/longer_base.def.json b/resources/definitions/longer_base.def.json index 4d6ba0beaf..fdc78b838b 100644 --- a/resources/definitions/longer_base.def.json +++ b/resources/definitions/longer_base.def.json @@ -62,7 +62,7 @@ "meshfix_maximum_resolution": { "value": "0.25" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retraction_amount": { "default_value": 5 }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'noskin'" }, diff --git a/resources/definitions/mingda_base.def.json b/resources/definitions/mingda_base.def.json index c6a294002e..6da76584f3 100644 --- a/resources/definitions/mingda_base.def.json +++ b/resources/definitions/mingda_base.def.json @@ -111,7 +111,7 @@ "meshfix_maximum_resolution": { "value": "0.05" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": true }, "retraction_amount": { "value": 2 }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'infill'" }, diff --git a/resources/definitions/mixware_hyper_k.def.json b/resources/definitions/mixware_hyper_k.def.json index 1b52bd9359..6f2adc246b 100644 --- a/resources/definitions/mixware_hyper_k.def.json +++ b/resources/definitions/mixware_hyper_k.def.json @@ -64,7 +64,7 @@ "meshfix_maximum_resolution": { "value": "0.25" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "raft_airgap": { "default_value": 0.24 }, "raft_margin": diff --git a/resources/definitions/modix_v3_base.def.json b/resources/definitions/modix_v3_base.def.json index 6f0205e59e..911d674e68 100644 --- a/resources/definitions/modix_v3_base.def.json +++ b/resources/definitions/modix_v3_base.def.json @@ -45,7 +45,7 @@ "material_final_print_temperature": { "value": "material_print_temperature" }, "material_initial_print_temperature": { "value": "material_print_temperature" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retraction_amount": { "value": 1 }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'infill'" }, diff --git a/resources/definitions/modix_v4_base.def.json b/resources/definitions/modix_v4_base.def.json index 932293d6df..71b99c7cae 100644 --- a/resources/definitions/modix_v4_base.def.json +++ b/resources/definitions/modix_v4_base.def.json @@ -45,7 +45,7 @@ "material_final_print_temperature": { "value": "material_print_temperature" }, "material_initial_print_temperature": { "value": "material_print_temperature" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retraction_amount": { "value": 1 }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'infill'" }, diff --git a/resources/definitions/rigid3d_base.def.json b/resources/definitions/rigid3d_base.def.json index 4940bc5a3c..116df0038b 100644 --- a/resources/definitions/rigid3d_base.def.json +++ b/resources/definitions/rigid3d_base.def.json @@ -48,7 +48,7 @@ "material_final_print_temperature": { "value": "material_print_temperature" }, "material_initial_print_temperature": { "value": "material_print_temperature" }, "minimum_interface_area": { "value": 5.0 }, - "minimum_support_area": { "value": 5 }, + "minimum_support_area": { "value": "5 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retraction_amount": { "value": 1.5 }, "retraction_combing": { "value": "'all'" }, diff --git a/resources/definitions/tank_m_base.def.json b/resources/definitions/tank_m_base.def.json index 069c6a4755..3692793259 100644 --- a/resources/definitions/tank_m_base.def.json +++ b/resources/definitions/tank_m_base.def.json @@ -48,7 +48,7 @@ "material_print_temperature": { "value": "195" }, "material_standby_temperature": { "value": "material_print_temperature" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "retraction_amount": { "value": 1.0 }, "retraction_speed": { "value": 40 }, "skirt_gap": { "value": 6.0 }, diff --git a/resources/definitions/tronxy_x.def.json b/resources/definitions/tronxy_x.def.json index 58dea24c90..683761a81b 100644 --- a/resources/definitions/tronxy_x.def.json +++ b/resources/definitions/tronxy_x.def.json @@ -56,7 +56,7 @@ "meshfix_maximum_resolution": { "value": "0.25" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retract_at_layer_change": { "value": true }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'noskin'" }, diff --git a/resources/definitions/two_trees_base.def.json b/resources/definitions/two_trees_base.def.json index 108d8df11f..ff01e46f6f 100644 --- a/resources/definitions/two_trees_base.def.json +++ b/resources/definitions/two_trees_base.def.json @@ -39,7 +39,7 @@ "meshfix_maximum_resolution": { "value": "0.25" }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 2 }, + "minimum_support_area": { "value": "2 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": "True" }, "retraction_amount": { "default_value": 7 }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'noskin'" }, diff --git a/resources/definitions/vivedino_base.def.json b/resources/definitions/vivedino_base.def.json index 5ffd06f3f0..a638fc105c 100644 --- a/resources/definitions/vivedino_base.def.json +++ b/resources/definitions/vivedino_base.def.json @@ -63,7 +63,7 @@ "meshfix_maximum_resolution": { "value": 0.25 }, "meshfix_maximum_travel_resolution": { "value": "meshfix_maximum_resolution" }, "minimum_interface_area": { "value": 10 }, - "minimum_support_area": { "value": 10 }, + "minimum_support_area": { "value": "10 if support_structure == 'normal' else 0" }, "optimize_wall_printing_order": { "value": true }, "retraction_combing": { "value": "'off' if retraction_hop_enabled else 'noskin'" }, "retraction_combing_max_distance": { "value": 30 },