From 55dcf31e3c10d60b13c44630c5a36055ef92ef94 Mon Sep 17 00:00:00 2001
From: Remco Burema <r.burema@ultimaker.com>
Date: Thu, 11 Apr 2019 16:24:51 +0200
Subject: [PATCH] Fix QML binding loop warnings for CustomConfiguration.

---
 .../Menus/ConfigurationMenu/CustomConfiguration.qml  | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/resources/qml/Menus/ConfigurationMenu/CustomConfiguration.qml b/resources/qml/Menus/ConfigurationMenu/CustomConfiguration.qml
index 708606f483..c60d4d48f0 100644
--- a/resources/qml/Menus/ConfigurationMenu/CustomConfiguration.qml
+++ b/resources/qml/Menus/ConfigurationMenu/CustomConfiguration.qml
@@ -205,7 +205,7 @@ Item
 
             Row
             {
-                height: visible ? childrenRect.height : 0
+                height: visible ? UM.Theme.getSize("setting_control").height : 0
                 visible: extrudersModel.count > 1  // If there is only one extruder, there is no point to enable/disable that.
 
                 Label
@@ -223,7 +223,7 @@ Item
                 {
                     checked: Cura.MachineManager.activeStack != null ? Cura.MachineManager.activeStack.isEnabled : false
                     enabled: !checked || Cura.MachineManager.numberExtrudersEnabled > 1 //Disable if it's the last enabled extruder.
-                    height: UM.Theme.getSize("setting_control").height
+                    height: parent.height
                     style: UM.Theme.styles.checkbox
 
                     /* Use a MouseArea to process the click on this checkbox.
@@ -242,7 +242,7 @@ Item
 
             Row
             {
-                height: visible ? childrenRect.height: 0
+                height: visible ? UM.Theme.getSize("print_setup_big_item").height : 0
                 visible: Cura.MachineManager.hasMaterials
 
                 Label
@@ -267,7 +267,7 @@ Item
                     tooltip: text
 
                     width: selectors.controlWidth
-                    height: UM.Theme.getSize("print_setup_big_item").height
+                    height: parent.height
 
                     style: UM.Theme.styles.print_setup_header_button
                     activeFocusOnPress: true
@@ -302,7 +302,7 @@ Item
 
             Row
             {
-                height: visible ? childrenRect.height: 0
+                height: visible ? UM.Theme.getSize("print_setup_big_item").height : 0
                 visible: Cura.MachineManager.hasVariants
 
                 Label
@@ -321,7 +321,7 @@ Item
                     id: variantSelection
                     text: Cura.MachineManager.activeVariantName
                     tooltip: Cura.MachineManager.activeVariantName
-                    height: UM.Theme.getSize("print_setup_big_item").height
+                    height: parent.height
                     width: selectors.controlWidth
                     style: UM.Theme.styles.print_setup_header_button
                     activeFocusOnPress: true;