From 54636c3421b23a6578561d924831a533911fdcd6 Mon Sep 17 00:00:00 2001 From: GregValiant <64202104+GregValiant@users.noreply.github.com> Date: Fri, 5 Apr 2024 13:32:28 -0400 Subject: [PATCH 1/2] Monitor Page Preheat values Change the default preheat values to the Initial Layer values. --- resources/qml/PrintMonitor.qml | 2 +- resources/qml/PrinterOutput/ExtruderBox.qml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/resources/qml/PrintMonitor.qml b/resources/qml/PrintMonitor.qml index 027586c381..cda7bb743b 100644 --- a/resources/qml/PrintMonitor.qml +++ b/resources/qml/PrintMonitor.qml @@ -129,7 +129,7 @@ ScrollView { id: bedTemperature containerStack: Cura.MachineManager.activeMachine - key: "material_bed_temperature" + key: "material_bed_temperature_layer_0" watchedProperties: ["value", "minimum_value", "maximum_value", "resolve"] storeIndex: 0 } diff --git a/resources/qml/PrinterOutput/ExtruderBox.qml b/resources/qml/PrinterOutput/ExtruderBox.qml index 46deec29ef..d6ce75a15a 100644 --- a/resources/qml/PrinterOutput/ExtruderBox.qml +++ b/resources/qml/PrinterOutput/ExtruderBox.qml @@ -22,7 +22,7 @@ Item { id: extruderTemperature containerStackId: Cura.ExtruderManager.extruderIds[position] - key: "material_print_temperature" + key: "material_print_temperature_layer_0" watchedProperties: ["value", "minimum_value", "maximum_value", "resolve"] storeIndex: 0 } From 3016820bee34375547a0ccfd812b75a95ee7386e Mon Sep 17 00:00:00 2001 From: Saumya Jain Date: Thu, 11 Apr 2024 09:47:40 +0200 Subject: [PATCH 2/2] fixing printer linter PR post --- .github/workflows/printer-linter-pr-post.yml | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/printer-linter-pr-post.yml b/.github/workflows/printer-linter-pr-post.yml index a71449299d..8bb1aaf028 100644 --- a/.github/workflows/printer-linter-pr-post.yml +++ b/.github/workflows/printer-linter-pr-post.yml @@ -39,6 +39,11 @@ jobs: echo "pr_id=$(cat printer-linter-result/pr-id.txt)" >> $GITHUB_ENV echo "pr_head_repo=$(cat printer-linter-result/pr-head-repo.txt)" >> $GITHUB_ENV echo "pr_head_ref=$(cat printer-linter-result/pr-head-ref.txt)" >> $GITHUB_ENV + if [[ -f "printer-linter-result/comment.md" ]]; then + echo "commentFileExists=true" >> $GITHUB_ENV + else + echo "commentFileExists=false" >> $GITHUB_ENV + fi - uses: actions/checkout@v3 with: @@ -72,16 +77,11 @@ jobs: mkdir printer-linter-result unzip printer-linter-result.zip -d printer-linter-result - - name: Get Pull Request Number - id: pr - run: echo "::set-output name=pull_request_number::$(gh pr view --json number -q .number || echo "")" - env: - GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} - - name: Run PR Comments + if: env.commentFileExists == 'true' uses: peter-evans/create-or-update-comment@v4 with: - issue-number: ${{ steps.pr.outputs.pull_request_number }} + issue-number: ${{ env.pr_id }} body-path: 'printer-linter-result/comment.md' - name: Run clang-tidy-pr-comments action