GitHub-Proxy/Cura
1
0
Fork 0
mirror of https://git.mirrors.martin98.com/https://github.com/Ultimaker/Cura synced 2025-05-19 07:27:29 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash when server sends invalid JSON data

Browse Source 
If readJSON fails, it puts an entry in the log and then returns None. This then crashes with a TypeError because you can't check for things to be in None.

Fixes Sentry issue CURA-3V5.
This commit is contained in:
Ghostkeeper 2022-05-19 11:35:58 +02:00
parent c41c59da13
commit 64b29779ca
No known key found for this signature in database
GPG Key ID: 68F39EA88EEED5FF
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
plugins/Marketplace/LocalPackageList.py
View File

@ -108,7 +108,7 @@ class LocalPackageList(PackageList):
:param reply: A reply containing information about a number of packages.
"""
response_data = HttpRequestManager.readJSON(reply)
if "data" not in response_data:
if response_data is None or "data" not in response_data:
Logger.error(
f"Could not interpret the server's response. Missing 'data' from response data. Keys in response: {response_data.keys()}")
return