From 6572d939bf841da1a63791f8cf21050bdbd71601 Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Thu, 28 Apr 2016 14:09:40 +0200 Subject: [PATCH] Convert for+if to list comprehension It's a simple filter, so why not? Contributes to issue CURA-844. --- plugins/VersionUpgrade/VersionUpgrade21to22/Profile.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/plugins/VersionUpgrade/VersionUpgrade21to22/Profile.py b/plugins/VersionUpgrade/VersionUpgrade21to22/Profile.py index 52518f3502..d3c2ba3233 100644 --- a/plugins/VersionUpgrade/VersionUpgrade21to22/Profile.py +++ b/plugins/VersionUpgrade/VersionUpgrade21to22/Profile.py @@ -64,9 +64,7 @@ class Profile: self._disabled_settings_defaults = [] if parser.has_section("disabled_defaults"): disabled_defaults_string = parser.get("disabled_defaults", "values") - for item in disabled_defaults_string.split(","): - if item != "": - self._disabled_settings_defaults.append(item) + self._disabled_settings_defaults = [item for item in disabled_defaults_string.split(",") if item != ""] # Split by comma. ## Serialises this profile as file format version 2. #