From 6720e1c2ee350ed84b129fdbc84d19558e0c1aef Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Tue, 23 May 2017 09:22:34 +0100 Subject: [PATCH 1/5] Added "group_walls" setting. --- resources/definitions/fdmprinter.def.json | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index be283f134f..51e1e42e42 100755 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -989,6 +989,14 @@ "default_value": false, "settable_per_mesh": true }, + "group_walls": + { + "label": "Group Walls", + "description": "Print all the walls for a single outline or hole before moving on to the next outline or hole.", + "type": "bool", + "default_value": false, + "settable_per_mesh": true + }, "alternate_extra_perimeter": { "label": "Alternate Extra Wall", From 26491da2b2433d6f1c6dc4fdcdde35a42b770d48 Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Wed, 24 May 2017 23:29:36 +0100 Subject: [PATCH 2/5] Rename group_walls setting to optimize_wall_printing_order. --- resources/definitions/fdmprinter.def.json | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 51e1e42e42..91d07c13d6 100755 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -989,10 +989,10 @@ "default_value": false, "settable_per_mesh": true }, - "group_walls": + "optimize_wall_printing_order": { - "label": "Group Walls", - "description": "Print all the walls for a single outline or hole before moving on to the next outline or hole.", + "label": "Optimize Wall Printing Order", + "description": "Optimize the order in which walls are printed so as to reduce the number of retractions and the distance travelled.", "type": "bool", "default_value": false, "settable_per_mesh": true From 85f0a012bbe80dd83251645cb0a2931c94fd3bfc Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Mon, 29 May 2017 17:44:45 +0100 Subject: [PATCH 3/5] Can't see any good reason why this shouldn't be turned on by default. --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 91d07c13d6..900f7be743 100755 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -994,7 +994,7 @@ "label": "Optimize Wall Printing Order", "description": "Optimize the order in which walls are printed so as to reduce the number of retractions and the distance travelled.", "type": "bool", - "default_value": false, + "default_value": true, "settable_per_mesh": true }, "alternate_extra_perimeter": From d267b60534446f551d48e7c715cd709903af1eff Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Wed, 31 May 2017 15:07:42 +0100 Subject: [PATCH 4/5] Add warning that enabling optimization can produce slower prints in some cases. --- resources/definitions/fdmprinter.def.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 900f7be743..04562b5992 100755 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -992,7 +992,7 @@ "optimize_wall_printing_order": { "label": "Optimize Wall Printing Order", - "description": "Optimize the order in which walls are printed so as to reduce the number of retractions and the distance travelled.", + "description": "Optimize the order in which walls are printed so as to reduce the number of retractions and the distance travelled. Most parts will benefit from this being enabled but some may actually take longer so please compare the print time estimates with and without optimization.", "type": "bool", "default_value": true, "settable_per_mesh": true From b74e25cb149bff776e511e2613b4a4dd472c3169 Mon Sep 17 00:00:00 2001 From: Mark Burton Date: Thu, 27 Jul 2017 16:47:07 +0100 Subject: [PATCH 5/5] Move optimize_wall_printing_order into the experimental category and change the default value to false. --- resources/definitions/fdmprinter.def.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json index 81321096fd..632b4760a8 100755 --- a/resources/definitions/fdmprinter.def.json +++ b/resources/definitions/fdmprinter.def.json @@ -1174,14 +1174,6 @@ "enabled": "wall_0_extruder_nr == wall_x_extruder_nr", "settable_per_mesh": true }, - "optimize_wall_printing_order": - { - "label": "Optimize Wall Printing Order", - "description": "Optimize the order in which walls are printed so as to reduce the number of retractions and the distance travelled. Most parts will benefit from this being enabled but some may actually take longer so please compare the print time estimates with and without optimization.", - "type": "bool", - "default_value": true, - "settable_per_mesh": true - }, "alternate_extra_perimeter": { "label": "Alternate Extra Wall", @@ -4972,6 +4964,14 @@ "description": "experimental!", "children": { + "optimize_wall_printing_order": + { + "label": "Optimize Wall Printing Order", + "description": "Optimize the order in which walls are printed so as to reduce the number of retractions and the distance travelled. Most parts will benefit from this being enabled but some may actually take longer so please compare the print time estimates with and without optimization.", + "type": "bool", + "default_value": false, + "settable_per_mesh": true + }, "draft_shield_enabled": { "label": "Enable Draft Shield",