From 783b26e5218744f1d41a68a647b934990e306395 Mon Sep 17 00:00:00 2001
From: Ghostkeeper <rubend@tutanota.com>
Date: Fri, 15 May 2020 13:11:28 +0200
Subject: [PATCH] While searching, search through all settings rather than just
 visible

This makes it consistent with the searching of the normal settings list. It also makes it easier to find certain things like the Cutting Mesh or something.
---
 plugins/PerObjectSettingsTool/SettingPickDialog.qml | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/plugins/PerObjectSettingsTool/SettingPickDialog.qml b/plugins/PerObjectSettingsTool/SettingPickDialog.qml
index 4e9295c05a..28ddb7e642 100644
--- a/plugins/PerObjectSettingsTool/SettingPickDialog.qml
+++ b/plugins/PerObjectSettingsTool/SettingPickDialog.qml
@@ -60,16 +60,12 @@ UM.Dialog
     CheckBox
     {
         id: toggleShowAll
-
         anchors
         {
             top: parent.top
             right: parent.right
         }
-
         text: catalog.i18nc("@label:checkbox", "Show all")
-        checked: listview.model.showAll
-        onClicked: listview.model.showAll = checked
     }
 
     ScrollView
@@ -85,7 +81,7 @@ UM.Dialog
         }
         ListView
         {
-            id:listview
+            id: listview
             model: UM.SettingDefinitionsModel
             {
                 id: definitionsModel
@@ -98,6 +94,7 @@ UM.Dialog
                     excluded_settings = excluded_settings.concat(settingPickDialog.additional_excluded_settings)
                     return excluded_settings
                 }
+                showAll: toggleShowAll.checked || filterInput.text !== ""
             }
             delegate:Loader
             {