From 7a85dc28d7440c89b5cfb299ff9f65d094378876 Mon Sep 17 00:00:00 2001 From: Jaime van Kessel Date: Mon, 2 Oct 2017 13:35:19 +0200 Subject: [PATCH] Changing to a printer with user settings doesn't trigger keep/discard popup anymore Fixes #2499 CURA-4384 --- resources/qml/Cura.qml | 2 +- resources/qml/SidebarSimple.qml | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/resources/qml/Cura.qml b/resources/qml/Cura.qml index 2399fb4395..b1644ff303 100755 --- a/resources/qml/Cura.qml +++ b/resources/qml/Cura.qml @@ -818,7 +818,7 @@ UM.MainWindow Connections { - target: Printer + target: CuraApplication onShowDiscardOrKeepProfileChanges: { discardOrKeepProfileChangesDialog.show() diff --git a/resources/qml/SidebarSimple.qml b/resources/qml/SidebarSimple.qml index 9987268d57..22ad9d460e 100644 --- a/resources/qml/SidebarSimple.qml +++ b/resources/qml/SidebarSimple.qml @@ -292,7 +292,8 @@ Item } onValueChanged: { - if(Cura.MachineManager.activeMachine != null) + // Only change if an active machine is set and the slider is visible at all. + if(Cura.MachineManager.activeMachine != null && visible) { //Prevent updating during view initializing. Trigger only if the value changed by user if(qualitySlider.value != qualityModel.activeQualityId)