From 7bf8e399ffbcb71b1592f4a1385ef2568e421662 Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Mon, 19 Mar 2018 09:45:29 +0100 Subject: [PATCH] Should always reslice upon settings changed CURA-5115 When we switch a model from "support mesh" for example to "normal", there will be no setting values in the per-object settings container, but we should still trigger a reslice because settings have been changed. --- cura/Settings/SettingOverrideDecorator.py | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/cura/Settings/SettingOverrideDecorator.py b/cura/Settings/SettingOverrideDecorator.py index 9054d9d04f..d7ae43f938 100644 --- a/cura/Settings/SettingOverrideDecorator.py +++ b/cura/Settings/SettingOverrideDecorator.py @@ -94,12 +94,7 @@ class SettingOverrideDecorator(SceneNodeDecorator): return any(bool(self._stack.getProperty(setting, "value")) for setting in self._non_printing_mesh_settings) def _onSettingChanged(self, instance, property_name): # Reminder: 'property' is a built-in function - object_has_instance_setting = False - for container in self._stack.getContainers(): - if container.hasProperty(instance, "value"): - object_has_instance_setting = True - break - if property_name == "value" and object_has_instance_setting: + if property_name == "value": # Trigger slice/need slicing if the value has changed. self._is_non_printing_mesh = self.evaluateIsNonPrintingMesh()