From 7f1930d452609c090cc893968e8a25f39c9a4c6a Mon Sep 17 00:00:00 2001 From: Ghostkeeper Date: Wed, 12 Apr 2017 09:15:42 +0200 Subject: [PATCH] Rewrite test_setPropertyUser It now only checks if setProperty is being called on the user changes instance, not what the result of that should be. Contributes to issue CURA-3497. --- tests/Settings/TestGlobalStack.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/Settings/TestGlobalStack.py b/tests/Settings/TestGlobalStack.py index 2db27e68b6..6dc395a598 100644 --- a/tests/Settings/TestGlobalStack.py +++ b/tests/Settings/TestGlobalStack.py @@ -543,9 +543,13 @@ def test_setNextStack(global_stack): ("layer_height", "default_value", 0.1337, 0.1337), ("layer_height", "is_bright_pink", "of course", "of course") ]) -def test_setPropertyUser(key, property, value, output_value, writable_global_stack): - writable_global_stack.setProperty(key, property, value) - assert writable_global_stack.userChanges.getProperty(key, property) == output_value +def test_setPropertyUser(key, property, value, output_value, global_stack): + user_changes = unittest.mock.MagicMock() + user_changes.getMetaDataEntry = unittest.mock.MagicMock(return_value = "user") + global_stack.userChanges = user_changes + + global_stack.setProperty(key, property, value) + global_stack.userChanges.setProperty.assert_called_once_with(key, property, value) ## Tests setting properties on specific containers on the global stack. @pytest.mark.parametrize("target_container", [