From 7f5bb70bee1a0489e5e26413f61f13df78d09dc1 Mon Sep 17 00:00:00 2001 From: Lipu Fei Date: Wed, 28 Feb 2018 12:45:58 +0100 Subject: [PATCH] Remove redundant setProperties CURA-4916 --- resources/qml/SidebarSimple.qml | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/resources/qml/SidebarSimple.qml b/resources/qml/SidebarSimple.qml index 6630291e56..dc8549f282 100644 --- a/resources/qml/SidebarSimple.qml +++ b/resources/qml/SidebarSimple.qml @@ -522,9 +522,6 @@ Item // Update the slider value to represent the rounded value infillSlider.value = roundedSliderValue - // Explicitly cast to string to make sure the value passed to Python is an integer. - infillDensity.setPropertyValue("value", String(roundedSliderValue)) - Cura.MachineManager.setSettingForAllExtruders("infill_sparse_density", "value", roundedSliderValue) } @@ -655,21 +652,19 @@ Item onClicked: { // Set to 90% only when enabling gradual infill + var newInfillDensity; if (parseInt(infillSteps.properties.value) == 0) { previousInfillDensity = parseInt(infillDensity.properties.value) - infillDensity.setPropertyValue("value", String(90)) - Cura.MachineManager.setSettingForAllExtruders("infill_sparse_density", "value", String(90)) + newInfillDensity = 90; } else { - infillDensity.setPropertyValue("value", String(previousInfillDensity)) - Cura.MachineManager.setSettingForAllExtruders("infill_sparse_density", "value", String(previousInfillDensity)) + newInfillDensity = previousInfillDensity; } + Cura.MachineManager.setSettingForAllExtruders("infill_sparse_density", "value", String(newInfillDensity)) var infill_steps_value = 0; if (parseInt(infillSteps.properties.value) == 0) infill_steps_value = 5; - infillSteps.setPropertyValue("value", infill_steps_value) - Cura.MachineManager.setSettingForAllExtruders("gradual_infill_steps", "value", infill_steps_value) }