feat: split skin_expand_distance into children and collapse expand_skins checkboxes (CURA-4270)

This commit is contained in:
Tim Kuipers 2017-09-01 16:00:19 +02:00
parent 93c56a9d47
commit 837a0b190b
7 changed files with 31 additions and 44 deletions

View File

@ -1567,51 +1567,44 @@
}
}
},
"expand_skins_into_infill":
"expand_skins_expand_distance":
{
"label": "Expand Skins Into Infill",
"description": "Expand skin areas of top and/or bottom skin of flat surfaces. By default, skins stop under the wall lines that surround infill but this can lead to holes appearing when the infill density is low. This setting extends the skins beyond the wall lines so that the infill on the next layer rests on skin.",
"type": "bool",
"default_value": false,
"label": "Skin Expand Distance",
"description": "The distance the skins are expanded into the infill. Higher values makes the skin attach better to the infill pattern and makes the walls on neighboring layers adhere better to the skin. Lower values save amount of material used.",
"unit": "mm",
"type": "float",
"default_value": 0,
"minimum_value": "-skin_preshrink",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true,
"children":
{
"expand_upper_skins":
"top_skin_expand_distance":
{
"label": "Expand Top Skins Into Infill",
"description": "Expand the top skin areas (areas with air above) so that they support infill above.",
"type": "bool",
"default_value": false,
"value": "expand_skins_into_infill",
"label": "Top Skin Expand Distance",
"description": "The distance the top skins are expanded into the infill. Higher values makes the skin attach better to the infill pattern and makes the walls on the layer above adhere better to the skin. Lower values save amount of material used.",
"unit": "mm",
"type": "float",
"default_value": 0,
"value": "expand_skins_expand_distance",
"minimum_value": "-top_skin_preshrink",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
},
"expand_lower_skins":
"bottom_skin_expand_distance":
{
"label": "Expand Bottom Skins Into Infill",
"description": "Expand the bottom skin areas (areas with air below) so that they are anchored by the infill layers above and below.",
"type": "bool",
"default_value": false,
"label": "Bottom Skin Expand Distance",
"description": "The distance the bottom skins are expanded into the infill. Higher values makes the skin attach better to the infill pattern and makes the skin adhere better to the walls on the layer below. Lower values save amount of material used.",
"unit": "mm",
"type": "float",
"default_value": 0,
"value": "expand_skins_expand_distance",
"minimum_value": "-bottom_skin_preshrink",
"limit_to_extruder": "top_bottom_extruder_nr",
"value": "expand_skins_into_infill",
"settable_per_mesh": true
}
}
},
"expand_skins_expand_distance":
{
"label": "Skin Expand Distance",
"description": "The distance the skins are expanded into the infill. The default distance is enough to bridge the gap between the infill lines and will stop holes appearing in the skin where it meets the wall when the infill density is low. A smaller distance will often be sufficient.",
"unit": "mm",
"type": "float",
"default_value": 2.8,
"value": "infill_line_distance * 1.4",
"minimum_value": "0",
"enabled": "expand_upper_skins or expand_lower_skins",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
},
"max_skin_angle_for_expansion":
{
"label": "Maximum Skin Angle for Expansion",
@ -1623,7 +1616,7 @@
"maximum_value_warning": "45",
"maximum_value": "90",
"default_value": 20,
"enabled": "expand_upper_skins or expand_lower_skins",
"enabled": "top_skin_expand_distance > 0 or bottom_skin_expand_distance > 0",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true,
"children":
@ -1637,7 +1630,7 @@
"default_value": 2.24,
"value": "top_layers * layer_height / math.tan(math.radians(max_skin_angle_for_expansion))",
"minimum_value": "0",
"enabled": "expand_upper_skins or expand_lower_skins",
"enabled": "top_skin_expand_distance > 0 or bottom_skin_expand_distance > 0",
"limit_to_extruder": "top_bottom_extruder_nr",
"settable_per_mesh": true
}

View File

@ -14,8 +14,7 @@ setting_version = 2
brim_width = 25
cool_min_layer_time_fan_speed_max = 6
cool_min_speed = 17
expand_skins_expand_distance = =line_width * 2
expand_upper_skins = True
top_skin_expand_distance = =line_width * 2
infill_before_walls = True
infill_line_width = =round(line_width * 0.7 / 0.8, 2)
infill_pattern = tetrahedral

View File

@ -14,8 +14,7 @@ setting_version = 2
brim_width = 25
cool_min_layer_time_fan_speed_max = 6
cool_min_speed = 17
expand_skins_expand_distance = =line_width * 2
expand_upper_skins = True
top_skin_expand_distance = =line_width * 2
infill_before_walls = True
infill_line_width = =round(line_width * 0.7 / 0.8, 2)
infill_pattern = tetrahedral

View File

@ -14,8 +14,7 @@ setting_version = 2
brim_width = 25
cool_min_layer_time_fan_speed_max = 6
cool_min_speed = 17
expand_skins_expand_distance = =line_width * 2
expand_upper_skins = True
top_skin_expand_distance = =line_width * 2
infill_before_walls = True
infill_line_width = =round(line_width * 0.7 / 0.8, 2)
infill_pattern = tetrahedral

View File

@ -13,8 +13,7 @@ setting_version = 2
[values]
brim_width = 8.75
cool_min_layer_time_fan_speed_max = 6
expand_skins_expand_distance = =line_width * 2
expand_upper_skins = True
top_skin_expand_distance = =line_width * 2
gradual_infill_step_height = =4 * layer_height
gradual_infill_steps = 5
infill_before_walls = True

View File

@ -13,8 +13,7 @@ setting_version = 2
[values]
brim_width = 8.75
cool_min_layer_time_fan_speed_max = 6
expand_skins_expand_distance = =line_width * 2
expand_upper_skins = True
top_skin_expand_distance = =line_width * 2
gradual_infill_step_height = =4 * layer_height
gradual_infill_steps = 5
infill_before_walls = True

View File

@ -13,8 +13,7 @@ setting_version = 2
[values]
brim_width = 8.75
cool_min_layer_time_fan_speed_max = 6
expand_skins_expand_distance = =line_width * 2
expand_upper_skins = True
top_skin_expand_distance = =line_width * 2
gradual_infill_step_height = =4 * layer_height
gradual_infill_steps = 5
infill_before_walls = True