diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md new file mode 100644 index 0000000000..a6327de3b6 --- /dev/null +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -0,0 +1,33 @@ +# Description + + + +## Type of change + + + +- [ ] Bug fix (non-breaking change which fixes an issue) +- [ ] New feature (non-breaking change which adds functionality) +- [ ] Printer definition file(s) +- [ ] Translations + +# How Has This Been Tested? + + + +- [ ] Test A +- [ ] Test B + +**Test Configuration**: +* Operating System: + +# Checklist: + + +- [ ] My code follows the style guidelines of this project as described in [UltiMaker Meta](https://github.com/Ultimaker/Meta) and [Cura QML best practices](https://github.com/Ultimaker/Cura/wiki/QML-Best-Practices) +- [ ] I have read the [Contribution guide](https://github.com/Ultimaker/Cura/blob/main/contributing.md) +- [ ] I have commented my code, particularly in hard-to-understand areas +- [ ] I have uploaded any files required to test this change \ No newline at end of file diff --git a/.github/workflows/conan-recipe-version.yml b/.github/workflows/conan-recipe-version.yml index 1aa61b73e4..ebd51de1ac 100644 --- a/.github/workflows/conan-recipe-version.yml +++ b/.github/workflows/conan-recipe-version.yml @@ -134,7 +134,7 @@ jobs: version = tools.Version(tag) except ConanException: continue - if version > latest_branch_version and latest_branch_version < tools.Version("10.0.0"): + if version > latest_branch_version and version < tools.Version("10.0.0"): # FIXME: stupid old Cura tags 13.04 etc. keep popping up latest_branch_version = version latest_branch_tag = repo.tag(tag)