From 8d69e845633f87455c1b79ffb2afa03acf7bb951 Mon Sep 17 00:00:00 2001
From: Mark Burton <markb@smartavionics.com>
Date: Mon, 29 Jan 2018 08:58:47 +0000
Subject: [PATCH] Refactor bridge settings.

Added bridge_wall_max_air_gap, bridge_wall_material_flow and bridge_skin_material_flow.

Removed bridge_skin_line_width and bridge_material_flow.
---
 resources/definitions/fdmprinter.def.json | 36 +++++++++++++++--------
 1 file changed, 23 insertions(+), 13 deletions(-)

diff --git a/resources/definitions/fdmprinter.def.json b/resources/definitions/fdmprinter.def.json
index 608577c7f0..d18f22c7b8 100644
--- a/resources/definitions/fdmprinter.def.json
+++ b/resources/definitions/fdmprinter.def.json
@@ -6212,19 +6212,16 @@
                     "enabled": "bridge_settings_enabled",
                     "settable_per_mesh": true
                 },
-                "bridge_skin_line_width":
+                "bridge_wall_max_air_gap":
                 {
-                    "label": "Bridge Skin Line Width",
-                    "description": "Width of a single skin line used when bridging.",
-                    "unit": "mm",
-                    "minimum_value": "0.001",
-                    "minimum_value_warning": "0.1 + 0.4 * machine_nozzle_size",
-                    "maximum_value_warning": "2 * machine_nozzle_size",
-                    "default_value": 0.4,
+                    "label": "Bridge Wall Max Air Gap",
+                    "description": "The maximum allowed width of the region of air below a wall line before the wall is printed using bridge settings. Expressed as a percentage of the wall line width. When the air gap is wider than this, the wall line is printed using the bridge settings. Otherwise, the wall line is printed using the normal settings. The lower the value, the more likely it is that overhung wall lines will be printed using bridge settings.",
+                    "unit": "%",
+                    "default_value": 50,
                     "type": "float",
-                    "value": "line_width",
+                    "minimum_value": "0",
+                    "maximum_value": "100",
                     "enabled": "bridge_settings_enabled",
-                    "limit_to_extruder": "top_bottom_extruder_nr",
                     "settable_per_mesh": true
                 },
                 "bridge_skin_speed":
@@ -6255,10 +6252,23 @@
                     "enabled": "bridge_settings_enabled",
                     "settable_per_mesh": true
                 },
-                "bridge_material_flow":
+                "bridge_skin_material_flow":
                 {
-                    "label": "Bridge Flow",
-                    "description": "Flow compensation: the amount of material extruded when bridging is multiplied by this value.",
+                    "label": "Bridge Skin Flow",
+                    "description": "Flow compensation: the amount of material extruded when bridging skin is multiplied by this value.",
+                    "unit": "%",
+                    "default_value": 100,
+                    "type": "float",
+                    "minimum_value": "5",
+                    "minimum_value_warning": "50",
+                    "maximum_value_warning": "150",
+                    "enabled": "bridge_settings_enabled",
+                    "settable_per_mesh": true
+                },
+                "bridge_wall_material_flow":
+                {
+                    "label": "Bridge Wall Flow",
+                    "description": "Flow compensation: the amount of material extruded when bridging walls is multiplied by this value.",
                     "unit": "%",
                     "default_value": 100,
                     "type": "float",